[coreboot-gerrit] Patch set updated for coreboot: driver/intel/wifi: Fix Makefile.inc
Naresh Solanki (naresh.solanki@intel.com)
gerrit at coreboot.org
Mon Jul 25 18:29:38 CEST 2016
Naresh Solanki (naresh.solanki at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15836
-gerrit
commit 714dd92f279a95b652583760039ad89ea76567ae
Author: Naresh G Solanki <naresh.solanki at intel.com>
Date: Mon Jul 25 18:01:45 2016 +0530
driver/intel/wifi: Fix Makefile.inc
*Makefile.inc should include wifi.c when DRIVERS_INTEL_WIFI is selected,
*Prevoiusly wifi.c was getting compiled based on config
PCIEXP_PLUGIN_SUPPORT which depends on PCI. This dependency is
incorrect.
*CONFIG_GENERATE_SMBIOS_TABLES is needed in wifi.c to add SMBIOS entry
during PCI enumeration based on mainboard Kconfig.
Hence right place for it is in wifi.c
Change-Id: Ifacd865a043e6a074bdb72cdba299681fa7ec7a9
Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
src/drivers/intel/wifi/Makefile.inc | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/drivers/intel/wifi/Makefile.inc b/src/drivers/intel/wifi/Makefile.inc
index 1435f8b..aab811c 100644
--- a/src/drivers/intel/wifi/Makefile.inc
+++ b/src/drivers/intel/wifi/Makefile.inc
@@ -11,9 +11,4 @@
# GNU General Public License for more details.
#
-# really?
-ifeq ($(CONFIG_GENERATE_SMBIOS_TABLES),y)
-
-ramstage-$(CONFIG_PCIEXP_PLUGIN_SUPPORT) += wifi.c
-
-endif
+ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c
More information about the coreboot-gerrit
mailing list