[coreboot-gerrit] New patch to review for coreboot: Kconfig: Clarify FRAMEBUFFER_KEEP_VESA_MODE

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Sun Jun 5 04:14:31 CEST 2016


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15072

-gerrit

commit fda91cbb1cf9dd1eec92b7200893688dc269b8a8
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Fri Jun 3 22:26:36 2016 +0200

    Kconfig: Clarify FRAMEBUFFER_KEEP_VESA_MODE
    
    This makes it easier to gasp what the option does without
    having to read the help.
    
    Change-Id: I51598532d09d8d9d7c2359ca15b2da408cc700d1
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/device/Kconfig | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/device/Kconfig b/src/device/Kconfig
index b1f8dae..61120a4 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -505,16 +505,27 @@ config FRAMEBUFFER_VESA_MODE
 	default 0x11B if FRAMEBUFFER_VESA_MODE_11B
 	default 0x117 if FRAMEBUFFER_VESA_MODE_USER
 
+choice
+	prompt "Framebuffer mode"
+
 config FRAMEBUFFER_KEEP_VESA_MODE
-	prompt "Keep VESA framebuffer"
+	prompt "Framebuffer mode"
 	bool
 	depends on PCI_OPTION_ROM_RUN_YABEL || PCI_OPTION_ROM_RUN_REALMODE || (MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG && MAINBOARD_DO_NATIVE_VGA_INIT)
 	help
 	  This option keeps the framebuffer mode set after coreboot finishes
-	  execution. If this option is enabled, coreboot will pass a
-	  framebuffer entry in its coreboot table and the payload will need a
-	  framebuffer driver. If this option is disabled, coreboot will switch
-	  back to text mode before handing control to a payload.
+	  execution.
+	  If this option is enabled, coreboot will pass a framebuffer entry in its
+	  coreboot table and the payload will need a framebuffer driver.
+
+config FRAMEBUFFER_KEEP_TEXT_MODE
+	prompt "Text mode"
+	bool
+	help
+	  If this option is enabled, coreboot will switch back to text mode
+	  before handing control to a payload.
+
+endchoice
 
 config BOOTSPLASH
 	prompt "Show graphical bootsplash"



More information about the coreboot-gerrit mailing list