[coreboot-gerrit] New patch to review for coreboot: amd/olivehillplus: Fix PCIe lane number comments.

Derek Waldner (derek.waldner.os@gmail.com) gerrit at coreboot.org
Tue Jun 7 15:40:47 CEST 2016


Derek Waldner (derek.waldner.os at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15095

-gerrit

commit 8e7337a2e34fabe4026a4f72ab8831db0285fe8e
Author: Derek Waldner <derek.waldner.os at gmail.com>
Date:   Mon Jun 6 13:54:26 2016 -0500

    amd/olivehillplus: Fix PCIe lane number comments.
    
    Correct the GPP PCIe lane number comments so that they match the code.
    
    Change-Id: If27c6a55ebedb0927dd9e8c7c9a833194e129a25
    Signed-off-by: Derek Waldner <derek.waldner.os at gmail.com>
---
 src/mainboard/amd/olivehillplus/OemCustomize.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/amd/olivehillplus/OemCustomize.c b/src/mainboard/amd/olivehillplus/OemCustomize.c
index 06a8f3d..ac60c42 100644
--- a/src/mainboard/amd/olivehillplus/OemCustomize.c
+++ b/src/mainboard/amd/olivehillplus/OemCustomize.c
@@ -18,6 +18,7 @@
 #define FILECODE PROC_GNB_PCIE_FAMILY_0X15_F15PCIECOMPLEXCONFIG_FILECODE
 
 static const PCIe_PORT_DESCRIPTOR PortList [] = {
+	/* Initialize Port descriptor (PCIe port, Lane 3, PCI Device 2, Function 5) */
 	{
 		0,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 3, 3),
@@ -27,7 +28,7 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 				PcieGenMaxSupported,
 				AspmDisabled, 0x01, 0)
 	},
-	/* Initialize Port descriptor (PCIe port, Lanes 1, PCI Device Number 2, ...) */
+	/* Initialize Port descriptor (PCIe port, Lane 2, PCI Device 2, Function 4) */
 	{
 		0,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 2, 2),
@@ -37,7 +38,7 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 				PcieGenMaxSupported,
 				AspmDisabled, 0x02, 0)
 	},
-	/* Initialize Port descriptor (PCIe port, Lanes 2, PCI Device Number 2, ...) */
+	/* Initialize Port descriptor (PCIe port, Lane 1, PCI Device 2, Function 3) */
 	{
 		0,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 1, 1),
@@ -47,7 +48,7 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 				PcieGenMaxSupported,
 				AspmDisabled, 0x03, 0)
 	},
-	/* Initialize Port descriptor (PCIe port, Lanes 3, PCI Device Number 2, ...) */
+	/* Initialize Port descriptor (PCIe port, Lane 0, PCI Device 2, Function 2) */
 	{
 		0,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 0, 0),
@@ -57,7 +58,7 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 				PcieGenMaxSupported,
 				AspmDisabled, 0x04, 0)
 	},
-	/* Initialize Port descriptor (PCIe port, Lanes 4-7, PCI Device Number 4, ...) */
+	/* Initialize Port descriptor (PCIe port, Lanes 4-7, PCI Device 2, Function 1) */
 	{
 		DESCRIPTOR_TERMINATE_LIST,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 4, 7),



More information about the coreboot-gerrit mailing list