[coreboot-gerrit] Patch set updated for coreboot: Revert "soc/intel/apollolake: Do not use StackBase FSP-M parameter"

Brandon Breitenstein (brandon.breitenstein@intel.com) gerrit at coreboot.org
Fri Jun 10 00:35:55 CEST 2016


Brandon Breitenstein (brandon.breitenstein at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15068

-gerrit

commit 03960e63b561960b63d62b70cb463901ad239f28
Author: Brandon Breitenstein <brandon.breitenstein at intel.com>
Date:   Sat Jun 4 00:52:21 2016 +0200

    Revert "soc/intel/apollolake: Do not use StackBase FSP-M parameter"
    
    This reverts commit 5ede3d8ccebde6f26c6b24f6458e57d99d5f3957.
    No longer needed due to FSP being updated, with the 139_40 release,
    to accept StackBase field
    
    BUG=chrome-os-partner:52784
    BRANCH=none
    TEST=built and booted with FSP 139_40
    
    Change-Id: Ic832d8dc4ca87631f5fef80d4d41558d9a72630a
    Signed-off-by: Brandon Breitenstein <brandon.breitenstein at intel.com>
---
 src/soc/intel/apollolake/romstage.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index dec5a18..2bfa345 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -235,14 +235,10 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd)
 	 * requests.
 	 * TODO: add checks to avoid overlap/conflict of CAR usage.
 	 */
-
-	/* fsp does not work with StackBase modified, so use default */
-#if 0
-	/* FIXME: remove this once FSP is fixed */
 	mupd->FspmArchUpd.StackBase = _car_region_end -
 					mupd->FspmArchUpd.StackSize;
-#endif
-	arch_upd->BootMode = FSP_BOOT_WITH_FULL_CONFIGURATION;
+
+	arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
 
 	if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {
 		if (!mrc_cache_get_current_with_version(&mrc_cache, 0)) {



More information about the coreboot-gerrit mailing list