[coreboot-gerrit] Patch merged into coreboot/master: Kconfig: Set VBOOT_OPROM_MATTERS for relevant non-x86 devices

gerrit at coreboot.org gerrit at coreboot.org
Sun Jun 12 12:11:30 CEST 2016


the following patch was just integrated into master:
commit 0a0f9c5d688c7efa496e60f5f285672c903c28d9
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Jun 1 14:53:48 2016 -0700

    Kconfig: Set VBOOT_OPROM_MATTERS for relevant non-x86 devices
    
    The VBOOT_OPROM_MATTERS configuration option signals to vboot that the
    board can skip display initialization in the normal boot path. It's name
    is a left-over from a time when this could only happen by avoiding
    loading the VGA option ROM on x86 devices. Now we have other
    boards that can skip their native display initialization paths too, and
    the effect to vboot is the same. (Really, we should rename oprom_matters
    and oprom_loaded to display_skippable and display_initialized or
    something, but I don't think that's worth the amount of repositories
    this would need to touch.)
    
    The only effect this still has in today's vboot is to reboot and
    explicitly request display initialization for EC software sync on
    VBOOT_EC_SLOW_UPDATE devices (which we haven't had yet on ARM). Still,
    the vboot flag just declares the capability (for skipping display init),
    and it should be set correctly regardless of whether that actually makes
    a difference on a given platform (right now). This patch updates all
    boards/SoCs that have a conditional path based on
    display_init_required() accordingly.
    
    BRANCH=None
    BUG=chrome-os-partner:51145
    TEST=Booted Oak, confirmed that there's no notable boot time impact.
    
    Change-Id: Ic7c77dbd8356d67af7aee54e7869f9ac35241b99
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Commit-Id: 9c242f7
    Original-Change-Id: I75e5cdda2ba2d111ea50ed2c7cdf94322679f1cd
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/348786
    Original-Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://review.coreboot.org/15113
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Furquan Shaikh <furquan at google.com>


See https://review.coreboot.org/15113 for details.

-gerrit



More information about the coreboot-gerrit mailing list