[coreboot-gerrit] New patch to review for coreboot: soc/intel/quark: Remove use of PDAT.bin file

Lee Leahy (lpleahyjr@gmail.com) gerrit at coreboot.org
Wed Jun 15 21:31:19 CEST 2016


Lee Leahy (lpleahyjr at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15205

-gerrit

commit 1f64739a377efb24a6fca017bc021de37043472f
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Wed Jun 15 12:29:51 2016 -0700

    soc/intel/quark: Remove use of PDAT.bin file
    
    Remove the Kconfig values which specify the PDAT file, its location
    and inclusion into the coreboot file system.
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I397aa22ada6c073c60485a735d6e2cb42bfd40ab
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/Kconfig      | 32 --------------------------------
 src/soc/intel/quark/Makefile.inc |  6 ------
 2 files changed, 38 deletions(-)

diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig
index 37b669d..6669d81 100644
--- a/src/soc/intel/quark/Kconfig
+++ b/src/soc/intel/quark/Kconfig
@@ -204,38 +204,6 @@ config RELOCATE_FSP_INTO_DRAM
 	  Relocate the FSP binary into DRAM before the call to SiliconInit.
 
 #####
-# FSP PDAT binary
-#     The following options control the FSP platform data binary
-#     file placement in the flash image.
-#####
-
-config ADD_FSP_PDAT_FILE
-	bool "Should the PDAT binary be added to the flash image?"
-	default n
-	depends on PLATFORM_USES_FSP1_1
-	help
-	  The PDAT file is required for the FSP 1.1 binary
-
-config FSP_PDAT_FILE
-	string
-	default "3rdparty/blobs/soc/intel/quark/pdat.bin"
-	depends on PLATFORM_USES_FSP1_1
-	depends on ADD_FSP_PDAT_FILE
-	help
-	  The path and filename of the Intel Galileo platform-data-patch (PDAT)
-	  binary. This binary file is generated by the platform-data-patch.py
-	  script released with the Quark BSP and contains the Ethernet address.
-
-config FSP_PDAT_LOC
-	hex
-	default 0xfff10000
-	depends on PLATFORM_USES_FSP1_1
-	depends on ADD_FSP_PDAT_FILE
-	help
-	  The location in CBFS that the PDAT is located. It must match the
-	  PCD PcdPlatformDataBaseAddress of Quark SoC FSP.
-
-#####
 # RMU binary
 #     The following options control the Quark chipset microcode file
 #     placement in the flash image.  This file is required to bring
diff --git a/src/soc/intel/quark/Makefile.inc b/src/soc/intel/quark/Makefile.inc
index edbb8be..f5b9746 100644
--- a/src/soc/intel/quark/Makefile.inc
+++ b/src/soc/intel/quark/Makefile.inc
@@ -56,12 +56,6 @@ fsp.bin-file := $(call strip_quotes,$(CONFIG_FSP_FILE))
 fsp.bin-position := $(CONFIG_FSP_LOC)
 fsp.bin-type := raw
 
-# Add the platform data file to the CBFS image
-cbfs-files-$(CONFIG_ADD_FSP_PDAT_FILE) += pdat.bin
-pdat.bin-file := $(call strip_quotes,$(CONFIG_FSP_PDAT_FILE))
-pdat.bin-position := $(CONFIG_FSP_PDAT_LOC)
-pdat.bin-type := raw
-
 # Add the chipset microcode file to the CBFS image
 cbfs-files-$(CONFIG_ADD_RMU_FILE) += rmu.bin
 rmu.bin-file := $(call strip_quotes,$(CONFIG_RMU_FILE))



More information about the coreboot-gerrit mailing list