[coreboot-gerrit] New patch to review for coreboot: mb/google: remove superfluous header includes in bdw chromeboxes

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Thu Jun 16 02:14:28 CEST 2016


Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15208

-gerrit

commit 3c2bba1cf05da81103207fc446253c047003111f
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Wed Jun 15 19:13:03 2016 -0500

    mb/google: remove superfluous header includes in bdw chromeboxes
    
    Change-Id: I71443c7547a113bf9b64d48fe5a85c6e2302c8aa
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/mainboard/google/guado/mainboard.c | 11 -----------
 src/mainboard/google/guado/spd/spd.c   |  6 ------
 src/mainboard/google/rikku/mainboard.c | 11 -----------
 src/mainboard/google/rikku/spd/spd.c   |  6 ------
 src/mainboard/google/tidus/mainboard.c | 11 -----------
 src/mainboard/google/tidus/spd/spd.c   |  6 ------
 6 files changed, 51 deletions(-)

diff --git a/src/mainboard/google/guado/mainboard.c b/src/mainboard/google/guado/mainboard.c
index f400c2f..3287a7e 100644
--- a/src/mainboard/google/guado/mainboard.c
+++ b/src/mainboard/google/guado/mainboard.c
@@ -14,19 +14,8 @@
  * GNU General Public License for more details.
  */
 
-#include <types.h>
-#include <string.h>
-#include <smbios.h>
-#include <device/device.h>
-#include <device/device.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <console/console.h>
-#include <pc80/mc146818rtc.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
-#include <arch/interrupt.h>
-#include <boot/coreboot_tables.h>
 #include "onboard.h"
 
 void mainboard_suspend_resume(void)
diff --git a/src/mainboard/google/guado/spd/spd.c b/src/mainboard/google/guado/spd/spd.c
index bfbebf5..5df4d14 100644
--- a/src/mainboard/google/guado/spd/spd.c
+++ b/src/mainboard/google/guado/spd/spd.c
@@ -13,13 +13,7 @@
  * GNU General Public License for more details.
  */
 
-#include <arch/byteorder.h>
-#include <cbfs.h>
-#include <console/console.h>
-#include <string.h>
-#include <soc/gpio.h>
 #include <soc/pei_data.h>
-#include <soc/romstage.h>
 #include <mainboard/google/guado/spd/spd.h>
 
 /* Copy SPD data for on-board memory */
diff --git a/src/mainboard/google/rikku/mainboard.c b/src/mainboard/google/rikku/mainboard.c
index 5bb8fab..16fe630 100644
--- a/src/mainboard/google/rikku/mainboard.c
+++ b/src/mainboard/google/rikku/mainboard.c
@@ -14,19 +14,8 @@
  * GNU General Public License for more details.
  */
 
-#include <types.h>
-#include <string.h>
-#include <smbios.h>
-#include <device/device.h>
-#include <device/device.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <console/console.h>
-#include <pc80/mc146818rtc.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
-#include <arch/interrupt.h>
-#include <boot/coreboot_tables.h>
 #include "onboard.h"
 
 void mainboard_suspend_resume(void)
diff --git a/src/mainboard/google/rikku/spd/spd.c b/src/mainboard/google/rikku/spd/spd.c
index 74879f2..4366d8a 100644
--- a/src/mainboard/google/rikku/spd/spd.c
+++ b/src/mainboard/google/rikku/spd/spd.c
@@ -13,13 +13,7 @@
  * GNU General Public License for more details.
  */
 
-#include <arch/byteorder.h>
-#include <cbfs.h>
-#include <console/console.h>
-#include <string.h>
-#include <soc/gpio.h>
 #include <soc/pei_data.h>
-#include <soc/romstage.h>
 #include <mainboard/google/rikku/spd/spd.h>
 
 /* Copy SPD data for on-board memory */
diff --git a/src/mainboard/google/tidus/mainboard.c b/src/mainboard/google/tidus/mainboard.c
index f400c2f..3287a7e 100644
--- a/src/mainboard/google/tidus/mainboard.c
+++ b/src/mainboard/google/tidus/mainboard.c
@@ -14,19 +14,8 @@
  * GNU General Public License for more details.
  */
 
-#include <types.h>
-#include <string.h>
-#include <smbios.h>
-#include <device/device.h>
-#include <device/device.h>
-#include <device/pci_def.h>
-#include <device/pci_ops.h>
-#include <console/console.h>
-#include <pc80/mc146818rtc.h>
 #include <arch/acpi.h>
 #include <arch/io.h>
-#include <arch/interrupt.h>
-#include <boot/coreboot_tables.h>
 #include "onboard.h"
 
 void mainboard_suspend_resume(void)
diff --git a/src/mainboard/google/tidus/spd/spd.c b/src/mainboard/google/tidus/spd/spd.c
index d02c925..bf5bda0 100644
--- a/src/mainboard/google/tidus/spd/spd.c
+++ b/src/mainboard/google/tidus/spd/spd.c
@@ -13,13 +13,7 @@
  * GNU General Public License for more details.
  */
 
-#include <arch/byteorder.h>
-#include <cbfs.h>
-#include <console/console.h>
-#include <string.h>
-#include <soc/gpio.h>
 #include <soc/pei_data.h>
-#include <soc/romstage.h>
 #include <mainboard/google/tidus/spd/spd.h>
 
 /* Copy SPD data for on-board memory */



More information about the coreboot-gerrit mailing list