[coreboot-gerrit] New patch to review for coreboot: ACPI S3: Cleanup RSDP reference
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Sat Jun 18 12:39:32 CEST 2016
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15240
-gerrit
commit 4344a70f6fe615c9f8c7664ae9676219a6e79a8d
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Fri Jun 17 08:44:40 2016 +0300
ACPI S3: Cleanup RSDP reference
Variable name shadows parameter name used on other functions,
and it can be local anyway after function removal.
Change-Id: I3164b15b33d877fef139f48ab2091e60e3124c3b
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/arch/x86/acpi.c | 10 +---------
src/arch/x86/include/arch/acpi.h | 1 -
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 5640ad0..cc6d2ad 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1071,24 +1071,16 @@ static acpi_rsdp_t *valid_rsdp(acpi_rsdp_t *rsdp)
return rsdp;
}
-static acpi_rsdp_t *rsdp;
-
-void *acpi_get_wakeup_rsdp(void)
-{
- return rsdp;
-}
-
void *acpi_find_wakeup_vector(void)
{
char *p, *end;
acpi_rsdt_t *rsdt;
acpi_facs_t *facs;
acpi_fadt_t *fadt = NULL;
+ acpi_rsdp_t *rsdp = NULL;
void *wake_vec;
int i;
- rsdp = NULL;
-
if (!acpi_is_wakeup())
return NULL;
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h
index 5674c3a24..30c888c 100644
--- a/src/arch/x86/include/arch/acpi.h
+++ b/src/arch/x86/include/arch/acpi.h
@@ -614,7 +614,6 @@ void acpi_resume(void *wake_vec);
void acpi_prepare_resume_backup(void);
void mainboard_suspend_resume(void);
void *acpi_find_wakeup_vector(void);
-void *acpi_get_wakeup_rsdp(void);
void acpi_jump_to_wakeup(void *wakeup_addr);
/* Returns 0 = S0, 1 = S1 ... */
More information about the coreboot-gerrit
mailing list