[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Remove hard reset workaround

Andrey Petrov (andrey.petrov@intel.com) gerrit at coreboot.org
Tue Jun 21 02:06:14 CEST 2016


Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15279

-gerrit

commit 4d7c7d5d858085d53abf53e7ae55fd3fac418e0a
Author: Andrey Petrov <andrey.petrov at intel.com>
Date:   Fri Jun 17 15:50:54 2016 -0700

    soc/intel/apollolake: Remove hard reset workaround
    
    Hard reset was demoted to soft reset, to workaround LDO issue in
    early silicon stepping. However, in certain cases cold reset is
    needed by FSP. Restore originial cold_reset().
    
    BUG=chrome-os-partner:54149
    BRANCH=none
    TEST=none
    
    Change-Id: I9754629abbcdf4ab19d92dee7d0ce7ab19aebe99
    Signed-off-by: Andrey Petrov <andrey.petrov at intel.com>
---
 src/soc/intel/apollolake/reset.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/soc/intel/apollolake/reset.c b/src/soc/intel/apollolake/reset.c
index d9a97a4..1bd6e4a 100644
--- a/src/soc/intel/apollolake/reset.c
+++ b/src/soc/intel/apollolake/reset.c
@@ -27,13 +27,10 @@
 #define RST_CPU			(1 << 2)
 #define SYS_RST			(1 << 1)
 
-/*
- * Temporary disable cold reboot on Apollolake platform due to USB LDO issue.
- * Should be fixed in later stepping.
- */
 void hard_reset(void)
 {
-	soft_reset();
+	outb(FULL_RST | RST_CPU | SYS_RST, RST_CNT);
+	halt();
 }
 
 void soft_reset(void)



More information about the coreboot-gerrit mailing list