[coreboot-gerrit] New patch to review for coreboot: AGESA boards: Undo binary split to romstage and ramstage

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Jun 24 06:26:44 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15341

-gerrit

commit 465c76bdde8ed131ead1d99a3b93b437714d5a63
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jun 24 07:13:37 2016 +0300

    AGESA boards: Undo binary split to romstage and ramstage
    
    Boards broken with commit:
      062ef1c AGESA boards: Split dispatcher to romstage and ramstage
    
    Revert the part that actually splits the build to romstage and
    ramstage until this is further investigated.
    
    While tested f14 boards had no identified issues with the approach,
    asus/f2a85-m with f15tn froze early in agesawrapper_amdinitearly().
    
    Change-Id: I7c2ff6de3884334cb0724b0cfdb6b0a304c11df8
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/vendorcode/amd/agesa/common/agesa-entry-cfg.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/vendorcode/amd/agesa/common/agesa-entry-cfg.h b/src/vendorcode/amd/agesa/common/agesa-entry-cfg.h
index e882f2e..b2aa483 100644
--- a/src/vendorcode/amd/agesa/common/agesa-entry-cfg.h
+++ b/src/vendorcode/amd/agesa/common/agesa-entry-cfg.h
@@ -2,8 +2,6 @@
 #define AGESA_ENTRY_CFG_H
 
 
-#if defined(__PRE_RAM__)
-
 #define AGESA_ENTRY_INIT_RESET		TRUE
 #define AGESA_ENTRY_INIT_EARLY		TRUE
 #define AGESA_ENTRY_INIT_POST		TRUE
@@ -17,14 +15,10 @@
 /* Move to ramstage? */
 #define AGESA_ENTRY_INIT_ENV		TRUE
 
-#else
-
 #define AGESA_ENTRY_INIT_MID		TRUE
 #define AGESA_ENTRY_INIT_LATE		TRUE
 #define AGESA_ENTRY_INIT_S3SAVE 	IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
 
-#endif
-
 /* Not required. */
 #define AGESA_ENTRY_INIT_GENERAL_SERVICES FALSE
 



More information about the coreboot-gerrit mailing list