[coreboot-gerrit] New patch to review for coreboot: google/reef: set 20K PULLUP on SDCARD DATA/CLK/CMD

[Freddy Paul (freddy.paul@intel.com)]

Freddy Paul (freddy.paul at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15345

-gerrit

commit 55a9e71d8506d8530a5328a3a65aebe1ca4f7bde
Author: Freddy Paul <freddy.paul at intel.com>
Date:   Fri Jun 24 08:23:43 2016 -0700

    google/reef: set 20K PULLUP on SDCARD DATA/CLK/CMD
    
    SD card need 20K PULLUP on D0-D3/CLOCK/COMMAND lines.
    Without this SDCARD will through data read/write errors.
    
    BUG=chrome-os-partner:54676
    TEST=Build and boot to OS.
         Verify SD card is detected and data read/write works well.
    
    Change-Id: I90da5b84dc2e488eb38f805322bd7b4dee394e5b
    Signed-off-by: Freddy Paul <freddy.paul at intel.com>
---
 src/mainboard/google/reef/gpio.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/google/reef/gpio.h b/src/mainboard/google/reef/gpio.h
index 23628eb..b41f5f9 100644
--- a/src/mainboard/google/reef/gpio.h
+++ b/src/mainboard/google/reef/gpio.h
@@ -56,13 +56,13 @@ static const struct pad_config gpio_table[] = {
 	PAD_CFG_GPI(GPIO_171, UP_20K, DEEP),	 /* SDIO_CMD */
 
 	/* SDCARD */
-	PAD_CFG_NF(GPIO_172, NATIVE, DEEP, NF1), /* SDCARD_CLK */
-	PAD_CFG_NF(GPIO_173, NATIVE, DEEP, NF1), /* SDCARD_D0 */
-	PAD_CFG_NF(GPIO_174, NATIVE, DEEP, NF1), /* SDCARD_D1 */
-	PAD_CFG_NF(GPIO_175, NATIVE, DEEP, NF1), /* SDCARD_D2 */
-	PAD_CFG_NF(GPIO_176, NATIVE, DEEP, NF1), /* SDCARD_D3 */
+	PAD_CFG_NF(GPIO_172, UP_20K, DEEP, NF1), /* SDCARD_CLK */
+	PAD_CFG_NF(GPIO_173, UP_20K, DEEP, NF1), /* SDCARD_D0 */
+	PAD_CFG_NF(GPIO_174, UP_20K, DEEP, NF1), /* SDCARD_D1 */
+	PAD_CFG_NF(GPIO_175, UP_20K, DEEP, NF1), /* SDCARD_D2 */
+	PAD_CFG_NF(GPIO_176, UP_20K, DEEP, NF1), /* SDCARD_D3 */
 	PAD_CFG_NF(GPIO_177, NATIVE, DEEP, NF1), /* SDCARD_CD_N */
-	PAD_CFG_NF(GPIO_178, NATIVE, DEEP, NF1), /* SDCARD_CMD */
+	PAD_CFG_NF(GPIO_178, UP_20K, DEEP, NF1), /* SDCARD_CMD */
 	PAD_CFG_NF(GPIO_179, NATIVE, DEEP, NF1), /* SDCARD_CLK_FB */
 	PAD_CFG_NF(GPIO_186, NATIVE, DEEP, NF1), /* SDCARD_LVL_WP */
 	/* EN_SD_SOCKET_PWR_L for SD slot power control. Default on. */