[coreboot-gerrit] Patch merged into coreboot/master: src/commonlib/lz4_wrapper: Correct inline asm for unaligned 64-bit copy

gerrit at coreboot.org gerrit at coreboot.org
Fri Jun 24 19:10:18 CEST 2016


the following patch was just integrated into master:
commit 82ef8ada82bd63ea7ce61843189fd4ee5de45cb5
Author: Benjamin Barenblat <bbaren at google.com>
Date:   Fri Jun 17 09:49:24 2016 -0700

    src/commonlib/lz4_wrapper: Correct inline asm for unaligned 64-bit copy
    
    Rewrite inline assembly for ARMv7+ to correctly annotate inputs and
    outputs.  On ARM GCC 6.1.1, this causes assembly output to change from
    the incorrect
    
    	@ r0 is allocated to hold dst and x0
    	@ r1 is allocated to hold src and x1
    	ldr r0, [r1]		@ clobbers dst!
    	ldr r1, [r1, #4]
    	str r0, [r0]
    	str r1, [r0, #4]
    
    to the correct
    
    	@ r0 is allocated to hold dst
    	@ r1 is allocated to hold src and x1
    	@ r3 is allocated to hold x0
    	ldr r3, [r1]
    	ldr r1, [r1, #4]
    	str r3, [r0]
    	str r1, [r0, #4]
    
    Also modify checkpatch.pl to ignore spaces before opening brackets when
    used in inline assembly.
    
    Change-Id: I255995f5e0a7b1a95375258755a93972c51d79b8
    Signed-off-by: Benjamin Barenblat <bbaren at google.com>
    Reviewed-on: https://review.coreboot.org/15216
    Tested-by: build bot (Jenkins)
    Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/15216 for details.

-gerrit



More information about the coreboot-gerrit mailing list