[coreboot-gerrit] New patch to review for coreboot: soc/apollolake: Populate smi_cmd field in FADT

Hannah Williams (hannah.williams@intel.com) gerrit at coreboot.org
Fri Jun 24 23:44:57 CEST 2016


Hannah Williams (hannah.williams at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15347

-gerrit

commit cf5fbc594a65bc15740e1d968a0284ba39c13063
Author: Hannah Williams <hannah.williams at intel.com>
Date:   Fri Jun 24 14:13:45 2016 -0700

    soc/apollolake: Populate smi_cmd field in FADT
    
    This will allow kernel to trigger a APM SMI to enable\disable SCI
    
    Change-Id: I1be79b7a3082c23fbaf204eff55360c46458e325
    Signed-off-by: Hannah Williams <hannah.williams at intel.com>
---
 src/soc/intel/apollolake/acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index d24416f..2c695a7 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -85,7 +85,7 @@ void acpi_fill_fadt(acpi_fadt_t * fadt)
 	fadt->header.revision = ACPI_FADT_REV_ACPI_5_0;
 
 	fadt->sci_int = acpi_sci_irq();
-	fadt->smi_cmd = 0;	/* No Smi Handler as SMI_CMD is 0*/
+	fadt->smi_cmd = APM_CNT;
 
 	fadt->pm1a_evt_blk = pmbase + PM1_STS;
 	fadt->pm1a_cnt_blk = pmbase + PM1_CNT;



More information about the coreboot-gerrit mailing list