[coreboot-gerrit] New patch to review for coreboot: cbfstool: Require "-m ARCH" for extract operation

[Antonello Dettori (dev@dettori.io)]

Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15438

-gerrit

commit 18ade94570f71411a1700d809ef855983f976503
Author: Antonello Dettori <dev at dettori.io>
Date:   Sun Jun 26 00:24:25 2016 +0200

    cbfstool: Require "-m ARCH" for extract operation
    
    Require the user to specify which architecture the payload
    was built on.
    
    Change-Id: I8ffe90a6af24e76739fd25456383a566edb0da7e
    Signed-off-by: Antonello Dettori <dev at dettori.io>
---
 util/cbfstool/cbfstool.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 7b30ce9..7405a22 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -915,6 +915,11 @@ static int cbfs_extract(void)
 		return 1;
 	}
 
+	if (param.arch == CBFS_ARCHITECTURE_UNKNOWN) {
+		ERROR("You need to specify -m ARCH.\n");
+		return 1;
+	}
+
 	struct cbfs_image image;
 	if (cbfs_image_from_buffer(&image, param.image_region,
 							param.headeroffset))
@@ -1230,7 +1235,7 @@ static void usage(char *name)
 			"List mutable (or, with -w, readable) image regions\n"
 	     " print [-r image,regions]                                    "
 			"Show the contents of the ROM\n"
-	     " extract [-r image,regions] [-m ARCH] -n NAME -f FILE        "
+	     " extract [-r image,regions] -m ARCH -n NAME -f FILE        "
 			"Extracts a raw payload from ROM\n"
 	     " write -r image,regions -f file [-u | -d]                    "
 			"Write file into same-size [or larger] raw region\n"