[coreboot-gerrit] New patch to review for coreboot: mainboard/ms7721: Support for MSI fm2-a75ma-e35 (MS-7721) motherboard.

Renze Nicolai (renze@rnplus.nl) gerrit at coreboot.org
Mon Jun 27 20:55:42 CEST 2016


Renze Nicolai (renze at rnplus.nl) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15449

-gerrit

commit 4ba1ca28c2f3e6adedd7b8372b8ff90521e6e5c8
Author: Renze Nicolai <renze at rnplus.nl>
Date:   Mon Jun 27 20:54:39 2016 +0200

    mainboard/ms7721: Support for MSI fm2-a75ma-e35 (MS-7721) motherboard.
    
    This commit adds support for the MSI fm2-a75ma-e35 (MS-7721) motherboard.
    
    The port is still work in progress: IRQ routing and ACPI still need to be checked and the power-led is non-functional.
    
    Change-Id: I2fd1de0886a56ea77f72c0db434d7a082092ba0e
    Signed-off-by: Renze Nicolai <renze at rnplus.nl>
---
 src/mainboard/msi/ms7721/BiosCallOuts.c |  40 +++++-----
 src/mainboard/msi/ms7721/Kconfig        |  30 ++++----
 src/mainboard/msi/ms7721/Kconfig.name   |   4 +-
 src/mainboard/msi/ms7721/OemCustomize.c |  27 +++++--
 src/mainboard/msi/ms7721/board_info.txt |  10 +--
 src/mainboard/msi/ms7721/buildOpts.c    |   4 +-
 src/mainboard/msi/ms7721/devicetree.cb  | 130 ++++++++++++++++----------------
 src/mainboard/msi/ms7721/dsdt.asl       |   2 +-
 src/mainboard/msi/ms7721/romstage.c     |  33 ++++----
 9 files changed, 150 insertions(+), 130 deletions(-)

diff --git a/src/mainboard/msi/ms7721/BiosCallOuts.c b/src/mainboard/msi/ms7721/BiosCallOuts.c
index 98bb067..72bf7eb 100644
--- a/src/mainboard/msi/ms7721/BiosCallOuts.c
+++ b/src/mainboard/msi/ms7721/BiosCallOuts.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2012 Advanced Micro Devices, Inc.
+ * Copyright (C) 2016 Renze Nicolai <renze at rnplus.nl>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -37,32 +38,31 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts);
 
 /**
- * ASUS F2A85-M board ALC887-VD Verb Table
+ * MSI MS-7721 board ALC887-VD Verb Table
  *
- * Copied from `/sys/class/sound/hwC1D0/init_pin_configs` when running
+ * Copied from `/sys/class/sound/hwC1D3/init_pin_configs` when running
  * the vendor BIOS.
  */
-const CODEC_ENTRY f2a85_m_alc887_VerbTbl[] = {
-	{0x11, 0x99430140},
-	{0x12, 0x411111f0},
-	{0x14, 0x01014010},
-	{0x15, 0x01011012},
-	{0x16, 0x01016011},
-	{0x17, 0x01012014},
-	{0x18, 0x01a19850},
-	{0x19, 0x02a19c60},
-	{0x1a, 0x0181305f},
-	{0x1b, 0x02214c20},
-	{0x1c, 0x411111f0},
-	{0x1d, 0x4005e601},
-	{0x1e, 0x01456130},
-	{0x1f, 0x411111f0},
-	{0xff, 0xffffffff}
+const CODEC_ENTRY ms7721_alc887_VerbTbl[] = {
+{0x11, 0x411111f0},
+{0x12, 0x411111f0},
+{0x14, 0x01014410},
+{0x15, 0x01011412},
+{0x16, 0x01016411},
+{0x17, 0x01012414},
+{0x18, 0x01a19c30},
+{0x19, 0x02a19c40},
+{0x1a, 0x0181343f},
+{0x1b, 0x02214c20},
+{0x1c, 0x411111f0},
+{0x1d, 0x4007f603},
+{0x1e, 0x411111f0},
+{0x1f, 0x411111f0}
 };
 
 static const CODEC_TBL_LIST CodecTableList[] =
 {
-	{0x10ec0887, (CODEC_ENTRY*)&f2a85_m_alc887_VerbTbl[0]},
+	{0x10ec0887, (CODEC_ENTRY*)&ms7721_alc887_VerbTbl[0]},
 	{(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
 };
 
@@ -97,7 +97,7 @@ static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINTN FchData, VOID *ConfigPtr)
 		FchParams_env->Usb.Xhci0Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
 		FchParams_env->Usb.Xhci1Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
 	}
-	printk(BIOS_DEBUG, "Done\n");
+	printk(BIOS_DEBUG, "Done.\n");
 
 	return AGESA_SUCCESS;
 }
diff --git a/src/mainboard/msi/ms7721/Kconfig b/src/mainboard/msi/ms7721/Kconfig
index 04eb936..df5cb5d 100644
--- a/src/mainboard/msi/ms7721/Kconfig
+++ b/src/mainboard/msi/ms7721/Kconfig
@@ -3,6 +3,8 @@
 #
 # Copyright (C) 2012 Advanced Micro Devices, Inc.
 # Copyright (C) 2012 Rudolf Marek <r.marek at assembler.cz>
+# Copyright (C) 2016 Renze Nicolai <renze at rnplus.nl>
+
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -14,7 +16,7 @@
 # GNU General Public License for more details.
 #
 
-if BOARD_ASUS_F2A85_M
+if BOARD_MSI_MS7721
 
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
@@ -25,42 +27,42 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_PIRQ_TABLE
 	select HAVE_MP_TABLE
 	select HAVE_ACPI_TABLES
-	select SUPERIO_ITE_IT8728F
+	select SUPERIO_FINTEK_F71869AD
 	select BOARD_ROMSIZE_KB_8192
 	select GFXUMA
 	select HUDSON_DISABLE_IMC
 
 choice
 	prompt "DDR3 memory voltage"
-	default BOARD_ASUS_F2A85_M_DDR3_VOLT_150
+	default BOARD_MSI_MS7721_DDR3_VOLT_150
 
-config BOARD_ASUS_F2A85_M_DDR3_VOLT_135
+config BOARD_MSI_MS7721_DDR3_VOLT_135
 	bool "1.35V"
 	help
 	  Set DRR3 memory voltage to 1.35V
-config BOARD_ASUS_F2A85_M_DDR3_VOLT_150
+config BOARD_MSI_MS7721_DDR3_VOLT_150
 	bool "1.50V"
 	help
 	  Set DRR3 memory voltage to 1.50V
-config BOARD_ASUS_F2A85_M_DDR3_VOLT_165
+config BOARD_MSI_MS7721_DDR3_VOLT_165
 	bool "1.65V"
 	help
 	  Set DRR3 memory voltage to 1.65V
 endchoice
 
-config BOARD_ASUS_F2A85_M_DDR3_VOLT_VAL
+config BOARD_MSI_MS7721_DDR3_VOLT_VAL
 	hex
-	default 0x9e if BOARD_ASUS_F2A85_M_DDR3_VOLT_135
-	default 0x0 if BOARD_ASUS_F2A85_M_DDR3_VOLT_150
-	default 0x1e if BOARD_ASUS_F2A85_M_DDR3_VOLT_165
+	default 0x9e if BOARD_MSI_MS7721_DDR3_VOLT_135
+	default 0x0 if BOARD_MSI_MS7721_DDR3_VOLT_150
+	default 0x1e if BOARD_MSI_MS7721_DDR3_VOLT_165
 
 config MAINBOARD_DIR
 	string
-	default asus/f2a85-m
+	default msi/ms7721
 
 config MAINBOARD_PART_NUMBER
 	string
-	default "F2A85-M"
+	default "MS-7721"
 
 config HW_MEM_HOLE_SIZEK
 	hex
@@ -92,7 +94,7 @@ config ONBOARD_VGA_IS_PRIMARY
 
 config VGA_BIOS_ID
 	string
-	default "1002,9993"
+	default "1002,990e"
 
 config HUDSON_LEGACY_FREE
 	bool
@@ -102,4 +104,4 @@ config POST_IO
 	bool
 	default n
 
-endif # BOARD_ASUS_F2A85_M
+endif # BOARD_MSI_MS7721
diff --git a/src/mainboard/msi/ms7721/Kconfig.name b/src/mainboard/msi/ms7721/Kconfig.name
index af6f628..bce5b99 100644
--- a/src/mainboard/msi/ms7721/Kconfig.name
+++ b/src/mainboard/msi/ms7721/Kconfig.name
@@ -1,2 +1,2 @@
-config BOARD_ASUS_F2A85_M
-	bool "F2A85-M"
+config BOARD_MSI_MS7721
+	bool "MS-7721 (FM2-A75MA-E35)"
diff --git a/src/mainboard/msi/ms7721/OemCustomize.c b/src/mainboard/msi/ms7721/OemCustomize.c
index 6348d5a..2316045 100644
--- a/src/mainboard/msi/ms7721/OemCustomize.c
+++ b/src/mainboard/msi/ms7721/OemCustomize.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2012 Advanced Micro Devices, Inc.
+ * Copyright (C) 2016 Renze Nicolai <renze at rnplus.nl>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -69,18 +70,30 @@
  */
 
 static const PCIe_PORT_DESCRIPTOR PortList [] = {
-	/* PCIe port, Lanes 8:23, PCI Device Number 2, blue x16 slot */
+	/* PCIe port, Lanes 8:23, PCI Device Number 2, x16 slot */
 	{
 		0,
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 8, 23),
 		PCIE_PORT_DATA_INITIALIZER (PortEnabled, ChannelTypeExt6db, 2, HotplugDisabled, PcieGenMaxSupported, PcieGenMaxSupported, AspmDisabled, 1)
 	},
-	/* PCIe port, Lanes 4:7, PCI Device Number 4, black x16 slot (in fact x4) */
+	/* PCIe port, Lane 4, PCI Device Number 4, Realtek LAN */
 	{
 		0,
-		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 4, 7),
+		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 4, 4),
 		PCIE_PORT_DATA_INITIALIZER (PortEnabled, ChannelTypeExt6db, 4, HotplugDisabled, PcieGenMaxSupported, PcieGenMaxSupported, AspmDisabled, 1)
 	},
+	/* PCIe port, Lane 5, PCI Device Number 5, x1 slot (1) */
+	{
+		0,
+		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 5, 5),
+		PCIE_PORT_DATA_INITIALIZER (PortEnabled, ChannelTypeExt6db, 5, HotplugDisabled, PcieGenMaxSupported, PcieGenMaxSupported, AspmDisabled, 1)
+	},
+	/* PCIe port, Lane 6, PCI Device Number 6, x1 slot (2) */
+	{
+		0,
+		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 6, 6),
+		PCIE_PORT_DATA_INITIALIZER (PortEnabled, ChannelTypeExt6db, 6, HotplugDisabled, PcieGenMaxSupported, PcieGenMaxSupported, AspmDisabled, 1)
+	},
 	/* PCIe port, Lanes 0:3, UMI link to SB, PCI Device Number 8 */
 	{
 		DESCRIPTOR_TERMINATE_LIST,
@@ -92,8 +105,8 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 /*
  * It is not known, if the setup is complete.
  *
- * Tested and works: VGA/DVI
- * Untested: HDMI
+ * Tested and works: HDMI
+ * Untested: VGA/DVI
  */
 static const PCIe_DDI_DESCRIPTOR DdiList [] = {
 	// DP0 to HDMI0/DP
@@ -205,7 +218,7 @@ static AGESA_STATUS OemInitMid(AMD_MID_PARAMS * InitMid)
  *----------------------------------------------------------------------------------------
  */
 
-#if IS_ENABLED(CONFIG_BOARD_ASUS_F2A85_M)
+#if IS_ENABLED(CONFIG_BOARD_MSI_MS7721)
 /*
  *  Platform Specific Overriding Table allows IBV/OEM to pass in platform information to AGESA
  *  (e.g. MemClk routing, the number of DIMM slots per channel,...). If PlatformSpecificTable
@@ -225,7 +238,7 @@ CONST PSO_ENTRY ROMDATA DefaultPlatformMemoryConfiguration[] = {
   */
   PSO_END
 };
-#endif /* CONFIG_BOARD_ASUS_F2A85_M */
+#endif /* CONFIG_BOARD_MSI_MS7721 */
 
 const struct OEM_HOOK OemCustomize = {
 	.InitEarly = OemInitEarly,
diff --git a/src/mainboard/msi/ms7721/board_info.txt b/src/mainboard/msi/ms7721/board_info.txt
index 091def6..6792e8e 100644
--- a/src/mainboard/msi/ms7721/board_info.txt
+++ b/src/mainboard/msi/ms7721/board_info.txt
@@ -1,7 +1,7 @@
 Category: desktop
-Board URL: http://www.asus.com/Motherboards/AMD_Socket_FM2/F2A85M/
-ROM package: DIP8
-ROM protocol: [http://www.winbond-usa.com/hq/enu/ProductAndSales/ProductLines/FlashMemory/SerialFlash/W25Q64BV.htm SPI]
-ROM socketed: y
+Board URL: https://www.msi.com/Motherboard/FM2-A75MA-E35.html
+ROM package: SOIC8
+ROM protocol: SPI
+ROM socketed: n
 Flashrom support: y
-Release year: 2013
+Release year: 2012
diff --git a/src/mainboard/msi/ms7721/buildOpts.c b/src/mainboard/msi/ms7721/buildOpts.c
index 5413b7c..59d66ae 100644
--- a/src/mainboard/msi/ms7721/buildOpts.c
+++ b/src/mainboard/msi/ms7721/buildOpts.c
@@ -326,11 +326,11 @@ CONST AP_MTRR_SETTINGS ROMDATA TrinityApMtrrSettingsList[] =
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
 //#define BLDCFG_IR_PIN_CONTROL	0x33
 //#define FCH_NO_XHCI_SUPPORT			FALSE
-GPIO_CONTROL   f2a85_m_gpio[] = {
+GPIO_CONTROL   ms7721_m_gpio[] = {
 //	{183, Function1, PullUpB},
 	{-1}
 };
-#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&f2a85_m_gpio[0])
+#define BLDCFG_FCH_GPIO_CONTROL_LIST           (&ms7721_m_gpio[0])
 
 // The following definitions specify the default values for various parameters in which there are
 // no clearly defined defaults to be used in the common file.  The values below are based on product
diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb
index 6b728d5..5213006 100644
--- a/src/mainboard/msi/ms7721/devicetree.cb
+++ b/src/mainboard/msi/ms7721/devicetree.cb
@@ -2,6 +2,7 @@
 # This file is part of the coreboot project.
 #
 # Copyright (C) 2012 Advanced Micro Devices, Inc.
+# Copyright (C) 2016 Renze Nicolai <renze at rnplus.nl>
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -27,25 +28,25 @@ chip northbridge/amd/agesa/family15tn/root_complex
 			chip northbridge/amd/agesa/family15tn # PCI side of HT root complex
 				device pci 0.0 on  end # Root Complex
 				device pci 0.2 on  end # IOMMU
-				device pci 1.0 on  end # Internal Graphics P2P bridge 0x99XX
+				device pci 1.0 on  end # Internal Graphics P2P bridge 0x990e
 				device pci 1.1 on  end # Internal Multimedia
-				device pci 2.0 on  end # PCIE SLOT0 x16 blue
-				device pci 3.0 off end # unused?
-				device pci 4.0 on  end # PCIE 4x black
-				device pci 5.0 off end # unused?
-				device pci 6.0 off end # unused?
+				device pci 2.0 on  end # PCIe x16
+				device pci 3.0 off end # -
+				device pci 4.0 on  end # PCIE Realtek LAN
+				device pci 5.0 on  end # PCIE x1 (1)
+				device pci 6.0 on  end # PCIE x1 (2)
 				device pci 7.0 off end # LAN
 				device pci 8.0 off end # NB/SB Link P2P bridge
 			end	#chip northbridge/amd/agesa/family15tn # PCI side of HT root complex
 
 			chip southbridge/amd/agesa/hudson # it is under NB/SB Link, but on the same pci bus
-				device pci 10.0 on  end # XHCI HC0
-				device pci 10.1 on  end # XHCI HC1
+				device pci 10.0 on  end # USB XHCI
+				device pci 10.1 on  end # USB XHCI
 				device pci 11.0 on  end # SATA
-				device pci 12.0 on  end # USB
-				device pci 12.2 on  end # USB
-				device pci 13.0 on  end # USB
-				device pci 13.2 on  end # USB
+				device pci 12.0 on  end # USB OHCI
+				device pci 12.2 on  end # USB EHCI
+				device pci 13.0 on  end # USB OHCI
+				device pci 13.2 on  end # USB EHCI
 				device pci 14.0 on      # SMBUS
 					chip drivers/generic/generic #dimm 0
 						device i2c 50 on end # 7-bit SPD address
@@ -55,61 +56,64 @@ chip northbridge/amd/agesa/family15tn/root_complex
 					end
 				end # SM
 				device pci 14.1 off end # IDE	0x439c
-				device pci 14.2 on  end # HDA	0x4383
+				device pci 14.2 on  end # Azallia (Audio)
 				device pci 14.3 on      # LPC	0x439d
-					chip superio/ite/it8728f
-						register hwm_ctl_register = "0xc0"
-						register hwm_main_ctl_register = "0x33"
-						register hwm_adc_temp_chan_en_reg = "0x38"
-						register hwm_fan1_ctl_pwm = "0x00"
-						register hwm_fan2_ctl_pwm = "0x00"
-						register hwm_fan3_ctl_pwm = "0x00"
-
-						device pnp 2e.0 off #  Floppy
-							io 0x60 = 0x3f0
-							irq 0x70 = 6
-							drq 0x74 = 2
-						end
-						device pnp 2e.1 on #  Com1
-							io 0x60 = 0x3f8
-							irq 0x70 = 4
-						end
-						device pnp 2e.2 off #  Com2
-							io 0x60 = 0x2f8
-							irq 0x70 = 3
-						end
-						device pnp 2e.3 off #  Parallel Port
-							io 0x60 = 0x378
-							irq 0x70 = 7
-						end
-						device pnp 2e.4 on #  Env Controller
-							io 0x60 = 0x290
-							io 0x62 = 0x220
-							irq 0x70 = 0
-						end
-						device pnp 2e.5 on #  Keyboard
-							io 0x60 = 0x60
-							io 0x62 = 0x64
-							irq 0x70 = 1
-						end
-						device pnp 2e.6 off #  Mouse
-							irq 0x70 = 12
-						end
-						device pnp 2e.7 on #  GPIO
-							io 0x60 = 0x228 #SMI
-							io 0x62 = 0x300 #Simple I/O
-							io 0x64 = 0x238 #Phony resource IT8603E does not have it
-							irq 0x70 = 0
-						end
-						device pnp 2e.a off end #  CIR
-					end	#superio/ite/it8728f
+					chip superio/fintek/f71869ad
+								register "multi_function_register_1" = "0x01"
+								register "multi_function_register_2" = "0x6f"
+								register "multi_function_register_3" = "0x24"
+								register "multi_function_register_4" = "0x00"
+								register "multi_function_register_5" = "0x60"
+# HWM configuration registers
+								register "hwm_smbus_address" = "0x98"
+								register "hwm_smbus_control_reg" = "0x02"
+								register "hwm_fan_type_sel_reg" = "0x00"
+								register "hwm_fan1_temp_adj_rate_reg" = "0x33"
+								register "hwm_fan_mode_sel_reg" = "0x07"
+								register "hwm_fan1_idx_rpm_mode" = "0x0e"
+								register "hwm_fan1_seg1_speed_count" = "0xff"
+								register "hwm_fan1_seg2_speed_count" = "0x0e"
+								register "hwm_fan1_seg3_speed_count" = "0x07"
+								register "hwm_fan1_temp_map_sel" = "0x8c"
+								device pnp 4e.00 off		# Floppy
+									io 0x60 = 0x3f0
+									irq 0x70 = 6
+									drq 0x74 = 2
+								end
+								device pnp 4e.01 on			# COM1
+									io 0x60 = 0x3f8
+									irq 0x70 = 4
+								end
+								device pnp 4e.02 off		# COM2 (not physically wired on board!)
+									io 0x60 = 0x2f8
+									irq 0x70 = 3
+								end
+								device pnp 4e.03 on		  # Parallel Port
+									io 0x60 = 0x378
+									irq 0x70 = 7
+									drq 0x74 = 3
+								end
+								device pnp 4e.04 on			# Hardware Monitor
+									io 0x60 = 0x225 # Fintek datasheet says 0x295.
+									irq 0x70 = 0
+								end
+								device pnp 4e.05 on     # KBC
+									io 0x60 = 0x060
+									irq 0x70 = 1 # Keyboard IRQ
+									irq 0x72 = 12 # Mouse IRQ
+								end
+								device pnp 4e.06 off end	# GPIO
+								device pnp 4e.07 on end	# WDT
+								device pnp 4e.08 off end	# CIR
+								device pnp 4e.0a on end	# PME
+							end # f71869ad
 				end	#device pci 14.3 # LPC
-				device pci 14.4 on  end # PCI 0x4384
-				device pci 14.5 on  end # USB 2
+				device pci 14.4 on  end # PCI 0x4384 (PCI slot on board)
+				device pci 14.5 on  end # USB OHCI
 				device pci 14.6 off end # Gec
 				device pci 14.7 off end # SD
-				device pci 15.0 on end # PCIe 0 - onboard PCIe 1x
-				device pci 15.1 on end # PCIe 1 onboard gigabit
+				device pci 15.0 off end # unused
+				device pci 15.1 off end # PCIe 1 onboard gigabit
 				device pci 15.2 off end # unused
 				device pci 15.3 off end # unused
 
diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl
index f022d4d..d92651b 100644
--- a/src/mainboard/msi/ms7721/dsdt.asl
+++ b/src/mainboard/msi/ms7721/dsdt.asl
@@ -19,7 +19,7 @@ DefinitionBlock (
 	"DSDT.AML",		/* Output filename */
 	"DSDT",			/* Signature */
 	0x02,			/* DSDT Revision, needs to be 2 for 64bit */
-	"ASUS  ",		/* OEMID */
+	"MSI   ",		/* OEMID */
 	"COREBOOT",		/* TABLE ID */
 	0x00010001		/* OEM Revision */
 	)
diff --git a/src/mainboard/msi/ms7721/romstage.c b/src/mainboard/msi/ms7721/romstage.c
index 709dbcd..1687f78 100644
--- a/src/mainboard/msi/ms7721/romstage.c
+++ b/src/mainboard/msi/ms7721/romstage.c
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2012 Advanced Micro Devices, Inc.
  * Copyright (C) 2012 Rudolf Marek <r.marek at assembler.cz>
+ * Copyright (C) 2016 Renze Nicolai <renze at rnplus.nl>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -33,16 +34,16 @@
 #include <southbridge/amd/agesa/hudson/smbus.h>
 #include <stdint.h>
 #include <string.h>
-#include <superio/ite/common/ite.h>
-#include <superio/ite/it8728f/it8728f.h>
+#include <superio/fintek/common/fintek.h>
+#include <superio/fintek/f71869ad/f71869ad.h>
 
 #define MMIO_NON_POSTED_START 0xfed00000
 #define MMIO_NON_POSTED_END   0xfedfffff
 #define SB_MMIO 0xFED80000
 #define SB_MMIO_MISC32(x) *(volatile u32 *)(SB_MMIO + 0xE00 + (x))
 
-#define SERIAL_DEV PNP_DEV(0x2e, IT8728F_SP1)
-#define GPIO_DEV PNP_DEV(0x2e, IT8728F_GPIO)
+/* Ensure Super I/O config address (i.e., 0x2e or 0x4e) matches that of devicetree.cb */
+#define SERIAL_DEV PNP_DEV(0x4e, F71869AD_SP1)
 
 static void sbxxx_enable_48mhzout(void)
 {
@@ -73,6 +74,8 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 
 	amd_initmmio();
 
+	post_code(0x29);
+
 	if (!cpu_init_detectedx && boot_cpu()) {
 
 		/* enable SIO LPC decode */
@@ -94,9 +97,9 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 
 		/* enable SIO clock */
 		sbxxx_enable_48mhzout();
-		ite_kill_watchdog(GPIO_DEV);
-		ite_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
-		ite_enable_3vsbsw(GPIO_DEV);
+
+		/* Enable serial console */
+		fintek_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
 		console_init();
 
 		/* turn on secondary smbus at b20 */
@@ -106,29 +109,29 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 		outb(byte, 0xcd7);
 
 		/* set DDR3 voltage */
-		byte = CONFIG_BOARD_ASUS_F2A85_M_DDR3_VOLT_VAL;
+		byte = CONFIG_BOARD_MSI_MS7721_DDR3_VOLT_VAL;
 
 		/* default is byte = 0x0, so no need to set it in this case */
 		if (byte)
 			do_smbus_write_byte(0xb20, 0x15, 0x3, byte);
 	}
-
 	/* Halt if there was a built in self test failure */
 	post_code(0x34);
 	report_bist_failure(bist);
 
 	/* Load MPB */
 	val = cpuid_eax(1);
-	printk(BIOS_DEBUG, "BSP Family_Model: %08x\n", val);
-	printk(BIOS_DEBUG, "cpu_init_detectedx = %08lx\n", cpu_init_detectedx);
-
+	printk(BIOS_DEBUG, "BSP Family_Model: %08x (cpu_init_detectedx: %08lx)\n", val, cpu_init_detectedx);
 	post_code(0x37);
+	printk(BIOS_DEBUG, "agesawrapper_amdinitreset()\n");
 	agesawrapper_amdinitreset();
 	post_code(0x39);
-
+	printk(BIOS_DEBUG, "agesawrapper_amdinitearly()\n");
 	agesawrapper_amdinitearly();
+	post_code(0x42);
 	int s3resume = acpi_is_wakeup_s3();
 	if (!s3resume) {
+		printk(BIOS_DEBUG, "Cold boot\n");
 		post_code(0x40);
 		agesawrapper_amdinitpost();
 		post_code(0x41);
@@ -136,18 +139,16 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 		disable_cache_as_ram();
 	} else {		/* S3 detect */
 		printk(BIOS_INFO, "S3 detected\n");
-
 		post_code(0x60);
 		agesawrapper_amdinitresume();
 		amd_initcpuio();
 		agesawrapper_amds3laterestore();
-
 		post_code(0x61);
 		prepare_for_resume();
 	}
 
 	post_code(0x50);
+	printk(BIOS_DEBUG, "Copy and run...\n");
 	copy_and_run();
-
 	post_code(0x54);  /* Should never see this post code. */
 }



More information about the coreboot-gerrit mailing list