[coreboot-gerrit] Patch set updated for coreboot: cbfstool: Require "-m ARCH" to extract payloads and stages

Antonello Dettori (dev@dettori.io) gerrit at coreboot.org
Tue Jun 28 01:36:03 CEST 2016


Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15438

-gerrit

commit 6c21628a3cb8bb9f6df44d086b7d33c42104bc79
Author: Antonello Dettori <dev at dettori.io>
Date:   Sun Jun 26 00:24:25 2016 +0200

    cbfstool: Require "-m ARCH" to extract payloads and stages
    
    Require the user to specify which architecture the payload/stage
    was built for before extracting it.
    
    Change-Id: I8ffe90a6af24e76739fd25456383a566edb0da7e
    Signed-off-by: Antonello Dettori <dev at dettori.io>
---
 util/cbfstool/cbfs_image.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c
index 5142a7a..1e38e4e 100644
--- a/util/cbfstool/cbfs_image.c
+++ b/util/cbfstool/cbfs_image.c
@@ -966,6 +966,11 @@ static int cbfs_stage_make_elf(struct buffer *buff, uint32_t arch)
 	size_t empty_sz;
 	int rmod_ret;
 
+	if (arch == CBFS_ARCHITECTURE_UNKNOWN) {
+		ERROR("You need to specify -m ARCH.\n");
+		return -1;
+	}
+
 	if (cbfs_stage_decompress(&stage, buff)) {
 		ERROR("Failed to decompress stage.\n");
 		return -1;
@@ -1047,6 +1052,11 @@ static int cbfs_payload_make_elf(struct buffer *buff, uint32_t arch)
 	size_t empty_sz;
 	int segments = 0;
 
+	if (arch == CBFS_ARCHITECTURE_UNKNOWN) {
+		ERROR("You need to specify -m ARCH.\n");
+		return -1;
+	}
+
 	/* Count the number of segments inside buffer */
 	while (true) {
 		uint32_t payload_type = 0;



More information about the coreboot-gerrit mailing list