[coreboot-gerrit] Patch set updated for coreboot: Obsoletes RAMBASE and RAMTOP

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Jun 29 10:58:31 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15250

-gerrit

commit 92def44888303dad301bf97d81a7977f3eb73199
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Jun 18 07:39:31 2016 +0300

    Obsoletes RAMBASE and RAMTOP
    
    There is no fixed region of RAMBASE..RAMTOP where ramstage
    gets loaded.
    
    Change-Id: Ie90611274fb011759661d5c46c8e35e5cca6533c
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/Kconfig                           | 2 +-
 src/arch/x86/Kconfig                  | 4 ----
 src/arch/x86/include/arch/memlayout.h | 4 ----
 src/arch/x86/memlayout.ld             | 2 +-
 src/northbridge/amd/agesa/Kconfig     | 4 ----
 src/northbridge/amd/pi/Kconfig        | 4 ----
 6 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 7043851..b158d11 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -243,7 +243,7 @@ config RELOCATABLE_MODULES
 
 config RELOCATABLE_RAMSTAGE
 	depends on EARLY_CBMEM_INIT
-	bool "Build the ramstage to be relocatable in 32-bit address space."
+	bool
 	default n
 	select RELOCATABLE_MODULES
 	help
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index af73a58..2750459 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -82,10 +82,6 @@ config SIPI_VECTOR_IN_ROM
 config RAMBASE
 	hex
 	default 0x100000
-
-config RAMTOP
-	hex
-	default 0x200000
 	depends on ARCH_X86
 
 # Traditionally BIOS region on SPI flash boot media was memory mapped right below
diff --git a/src/arch/x86/include/arch/memlayout.h b/src/arch/x86/include/arch/memlayout.h
index 5f5cba6..840ceb0 100644
--- a/src/arch/x86/include/arch/memlayout.h
+++ b/src/arch/x86/include/arch/memlayout.h
@@ -24,8 +24,4 @@
 #define ARCH_STAGE_HAS_BSS_SECTION 0
 #endif
 
-#if !defined(CONFIG_RAMTOP) || !CONFIG_RAMTOP
-# error "CONFIG_RAMTOP not configured"
-#endif
-
 #endif /* __ARCH_MEMLAYOUT_H */
diff --git a/src/arch/x86/memlayout.ld b/src/arch/x86/memlayout.ld
index e6db0b8..a007272 100644
--- a/src/arch/x86/memlayout.ld
+++ b/src/arch/x86/memlayout.ld
@@ -26,7 +26,7 @@ SECTIONS
 	 * conditionalize with macros.
 	 */
 #if ENV_RAMSTAGE
-	RAMSTAGE(CONFIG_RAMBASE, CONFIG_RAMTOP - CONFIG_RAMBASE)
+	RAMSTAGE(CONFIG_RAMBASE, 8M)
 
 #elif ENV_ROMSTAGE
 	/* The 1M size is not allocated. It's just for basic size checking.
diff --git a/src/northbridge/amd/agesa/Kconfig b/src/northbridge/amd/agesa/Kconfig
index d5cff80..37bf3c4 100644
--- a/src/northbridge/amd/agesa/Kconfig
+++ b/src/northbridge/amd/agesa/Kconfig
@@ -35,8 +35,4 @@ config HEAP_SIZE
 	hex
 	default 0xc0000
 
-config RAMTOP
-	hex
-	default 0x400000
-
 endif # NORTHBRIDGE_AMD_AGESA
diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig
index cb72416..eea2897 100644
--- a/src/northbridge/amd/pi/Kconfig
+++ b/src/northbridge/amd/pi/Kconfig
@@ -40,10 +40,6 @@ config HW_MEM_HOLE_SIZE_AUTO_INC
 	bool
 	default n
 
-config RAMTOP
-	hex
-	default 0x1000000
-
 config HEAP_SIZE
 	hex
 	default 0xc0000



More information about the coreboot-gerrit mailing list