[coreboot-gerrit] New patch to review for coreboot: cbfstool: Use fixed width data types for e820entry struct.

Werner Zeh (werner.zeh@siemens.com) gerrit at coreboot.org
Wed Mar 2 18:02:15 CET 2016


Werner Zeh (werner.zeh at siemens.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13875

-gerrit

commit 4f3ecaefc45d562b5de881c6d63778915d706954
Author: Werner Zeh <werner.zeh at siemens.com>
Date:   Wed Mar 2 17:55:31 2016 +0100

    cbfstool: Use fixed width data types for e820entry struct.
    
    In e820entry struct, the members are defined using
    standard types. This can lead to different structure size
    when compiling on 32 bit vs. 64 bit environment. This in turn
    will affect the size of the struct linux_params.
    Using the fixed width types resolves this issue and ensures
    that the size of the structures will have the same length
    on both 32 and 64 bit systems.
    
    Change-Id: I1869ff2090365731e79b34950446f1791a083d0f
    Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
 util/cbfstool/linux.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/util/cbfstool/linux.h b/util/cbfstool/linux.h
index 529d239..b96f447 100644
--- a/util/cbfstool/linux.h
+++ b/util/cbfstool/linux.h
@@ -31,9 +31,9 @@ typedef uint64_t u64;
 
 #define E820MAX	32		/* number of entries in E820MAP */
 struct e820entry {
-	unsigned long long addr;	/* start of memory segment */
-	unsigned long long size;	/* size of memory segment */
-	unsigned long type;	/* type of memory segment */
+	u64 addr;		/* start of memory segment */
+	u64 size;		/* size of memory segment */
+	u32 type;		/* type of memory segment */
 #define E820_RAM	1
 #define E820_RESERVED	2
 #define E820_ACPI	3	/* usable as RAM once ACPI tables have been read */



More information about the coreboot-gerrit mailing list