[coreboot-gerrit] New patch to review for coreboot: Kconfig: hide useless options on ARM.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Fri Mar 4 09:29:09 CET 2016
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13904
-gerrit
commit cb781012a3445053798f2c487a9cede9cdcb5d36
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Fri Mar 4 09:20:20 2016 +0100
Kconfig: hide useless options on ARM.
Those options have no effect or lead to compile error on ARM due
to fundamental incompatibilities. Add proper "depends on" clauses
to hide them.
Change-Id: I860fbd331439c25efd8aa92023195fda3add2e2c
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/arch/x86/Kconfig | 1 +
src/console/Kconfig | 5 +++++
src/device/Kconfig | 2 ++
src/drivers/sil/3114/Kconfig | 1 +
4 files changed, 9 insertions(+)
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 2257cb6..a90b04e 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -155,6 +155,7 @@ config ID_SECTION_OFFSET
config COMPILE_IN_DSDT
bool "compile in DSDT and use that over DSDT in CBFS"
+ depends on HAVE_ACPI_TABLES
default n
# 64KiB default bootblock size when employing C_ENVIRONMENT_BOOTBLOCK.
diff --git a/src/console/Kconfig b/src/console/Kconfig
index 847d17e..90fb426 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -133,6 +133,7 @@ endif # CONSOLE_SERIAL
config SPKMODEM
bool "spkmodem (console on speaker) console output"
default n
+ depends on ARCH_X86
help
Send coreboot debug output through speaker
@@ -150,12 +151,14 @@ config CONSOLE_USB
config ONBOARD_VGA_IS_PRIMARY
bool "Use onboard VGA as primary video device"
default n
+ depends on PCI
help
If not selected, the last adapter found will be used.
config CONSOLE_NE2K
bool "Network console over NE2000 compatible Ethernet adapter"
default n
+ depends on PCI
help
Send coreboot debug output to a Ethernet console, it works
same way as Linux netconsole, packets are received to UDP
@@ -357,8 +360,10 @@ config POST_DEVICE_NONE
bool "None"
config POST_DEVICE_LPC
bool "LPC"
+ depends on PCI
config POST_DEVICE_PCI_PCIE
bool "PCI/PCIe"
+ depends on PCI
endchoice
config POST_IO
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 70a362f..d156d36 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -303,6 +303,7 @@ config SUBSYSTEM_DEVICE_ID
config VGA_BIOS
bool "Add a VGA BIOS image"
+ depends on ARCH_X86
help
Select this option if you have a VGA BIOS image that you would
like to add to your ROM.
@@ -352,6 +353,7 @@ config MBI_FILE
config PXE_ROM
bool "Add a PXE ROM image"
+ depends on ARCH_X86
help
Select this option if you have a PXE ROM image that you would
like to add to your ROM.
diff --git a/src/drivers/sil/3114/Kconfig b/src/drivers/sil/3114/Kconfig
index 25bb202..151636c 100644
--- a/src/drivers/sil/3114/Kconfig
+++ b/src/drivers/sil/3114/Kconfig
@@ -1,6 +1,7 @@
config DRIVERS_SIL_3114
bool "Silicon Image SIL3114"
default n
+ depends on PCI
help
It sets PCI class to IDE compatible native mode, allowing
SeaBIOS, FILO etc... to boot from it.
More information about the coreboot-gerrit
mailing list