[coreboot-gerrit] New patch to review for coreboot: google/oak: Remove obsolete Rev0 setting

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Mar 8 22:35:25 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13974

-gerrit

commit 64a7f4e6467b875207915603b3d24298c827c0a1
Author: Koro Chen <koro.chen at mediatek.com>
Date:   Wed Dec 30 17:50:56 2015 +0800

    google/oak: Remove obsolete Rev0 setting
    
    BRANCH=none
    BUG=none
    TEST=emerge-oak coreboot
    
    Change-Id: I65aa87e88cf812fdb490933de1a3b121866a2694
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 8f703f7e71ae6ffc0f1ac0e70486d087a28da5ba
    Original-Change-Id: I8d794464d45ea69f9a46f7ebc505f6ec2127f204
    Original-Signed-off-by: Koro Chen <koro.chen at mediatek.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/319987
    Original-Commit-Ready: Yidi Lin <yidi.lin at mediatek.com>
    Original-Tested-by: Yidi Lin <yidi.lin at mediatek.com>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/mainboard/google/oak/mainboard.c | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c
index e58d168..fe6bbcc 100644
--- a/src/mainboard/google/oak/mainboard.c
+++ b/src/mainboard/google/oak/mainboard.c
@@ -100,24 +100,12 @@ static void configure_audio(void)
 {
 	mtcmos_audio_power_on();
 
-	/* regulator for codecs */
-	switch (board_id()) {
-	case 0:
-		/* vgp1 set to 1.22V */
-		mt6391_configure_ldo(LDO_VCAMD, LDO_1P22);
-		/* vgp4 set to 1.8V */
-		mt6391_configure_ldo(LDO_VGP4, LDO_1P8);
-		break;
-	default:
-		/* board from Rev1 */
-		/* vgp1 set to 1.8V */
-		mt6391_configure_ldo(LDO_VCAMD, LDO_1P8);
-		/* delay 1ms for realtek's power sequence request */
-		mdelay(1);
-		/* vcama set to 1.8V */
-		mt6391_configure_ldo(LDO_VCAMA, LDO_1P8);
-		break;
-	}
+	/* vgp1 set to 1.8V */
+	mt6391_configure_ldo(LDO_VCAMD, LDO_1P8);
+	/* delay 1ms for realtek's power sequence request */
+	mdelay(1);
+	/* vcama set to 1.8V */
+	mt6391_configure_ldo(LDO_VCAMA, LDO_1P8);
 
 	/* reset ALC5676 */
 	gpio_output(PAD_LCM_RST, 1);



More information about the coreboot-gerrit mailing list