[coreboot-gerrit] Patch set updated for coreboot: src/lib/trace.c: Make address size generic

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Mar 10 04:21:34 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13962

-gerrit

commit 319c5f8c38c153def56a9fa5b5f5b88a52be4b89
Author: Martin Roth <martinroth at google.com>
Date:   Tue Mar 8 12:17:44 2016 -0700

    src/lib/trace.c: Make address size generic
    
    On platforms that didn't use 32-bit addresses, enabling the
    CONFIG_TRACE option (Trace function calls) would break the build due
    to a cast from a pointer of a different size.
    
    This fixes this warning:
    src/lib/trace.c:29:58: error: cast from pointer to integer of different
    size [-Werror=pointer-to-int-cast]
    
    Change-Id: Iaab13c1891b6af7559ea6982ecc6e74c09dd0395
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/lib/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/trace.c b/src/lib/trace.c
index 8c29ab3..8f52331 100644
--- a/src/lib/trace.c
+++ b/src/lib/trace.c
@@ -26,7 +26,7 @@ void __cyg_profile_func_enter( void *func, void *callsite)
 		return;
 
 	DISABLE_TRACE
-	printk(BIOS_INFO, "~0x%08x(0x%08x)\n", (uint32_t) func, (uint32_t) callsite);
+	printk(BIOS_INFO, "~0x%p(0x%p)\n", func, callsite);
 	ENABLE_TRACE
 }
 



More information about the coreboot-gerrit mailing list