[coreboot-gerrit] Patch merged into coreboot/master: coreinfo/cbfs: Don't assume that the free space is at the end

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 11 18:41:48 CET 2016


the following patch was just integrated into master:
commit 1aca8b898da359fbde2976ba0d031de8be6e857c
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Thu Mar 10 04:32:46 2016 +0100

    coreinfo/cbfs: Don't assume that the free space is at the end
    
    On emulation/qemu-i440fx, I get this layout:
    
      Name                           Offset     Type         Size
      cbfs master header             0x0        cbfs header  32
      fallback/romstage              0x80       stage        14284
      fallback/ramstage              0x38c0     stage        42382
      fallback/payload               0xdec0     payload      1165052
      config                         0x12a600   raw          352
      revision                       0x12a7c0   raw          572
      cmos_layout.bin                0x12aa40   cmos_layout  772
      fallback/dsdt.aml              0x12ad80   raw          4000
      img/coreinfo                   0x12bd80   payload      1165052
      (empty)                        0x2484c0   null         1799192
      bootblock                      0x3ff900   bootblock    1456
    
    ... which coreinfo displays in the following way, without this patch:
    
      cbfs master header
      fallback/romstage
      fallback/ramstage
      fallback/payload
      config
      revision
      cmos_layout.bin
      fallback/dsdt.aml
      img/coreinfo
    
      <free space>
    
    
    Change-Id: I21eb1dfbe52921843d28683c9396e9b27caa4fbf
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
    Reviewed-on: https://review.coreboot.org/14024
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/14024 for details.

-gerrit



More information about the coreboot-gerrit mailing list