[coreboot-gerrit] Patch merged into coreboot/master: genbuild_h: Fix numeric comparison to remove error
gerrit at coreboot.org
gerrit at coreboot.org
Mon Mar 14 23:37:14 CET 2016
the following patch was just integrated into master:
commit 8ba235e2acf2c15ca5484ed51001d6555b082a51
Author: Martin Roth <martinroth at google.com>
Date: Sat Mar 12 20:15:18 2016 -0700
genbuild_h: Fix numeric comparison to remove error
Change the comparison of build_timeless from -eq to =
This was generating an error if BUILD_TIMELESS wasn't set:
util/genbuild_h/genbuild_h.sh: line 27: [: : integer expression expected
This wasn't causing the script to fail, and won't even if 'set -e' is
added to the script because the error happens inside an 'if' clause,
which is specifically excluded from failue on 'set -e'.
Change-Id: I6a4e147ece23e83ee682d72db35be9e5d4088c78
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/14080
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Alexander Couzens <lynxis at fe80.eu>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See https://review.coreboot.org/14080 for details.
-gerrit
More information about the coreboot-gerrit
mailing list