[coreboot-gerrit] New patch to review for coreboot: Documentation: x86 MTRR setup, TempRamExit and MTRR loading

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Wed Mar 16 21:41:16 CET 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14113

-gerrit

commit e3fe47ed9d828198c6dbe0c27c5c9b1d2d3f8d5c
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Sun Jan 31 12:19:13 2016 -0800

    Documentation: x86 MTRR setup, TempRamExit and MTRR loading
    
    Document how to test TempRamExit and verify the MTRR setup and loading.
    
    TEST=None
    
    Change-Id: I57a604fa139edac4b05453547d3caf185db491e0
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 Documentation/Intel/development.html | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/Intel/development.html b/Documentation/Intel/development.html
index a36acaa..a2ba278 100644
--- a/Documentation/Intel/development.html
+++ b/Documentation/Intel/development.html
@@ -97,6 +97,7 @@
   <li>Disable the
     <a target="_blank" href="SoC/soc.html#DisableShadowRom">Shadow ROM</a>
   </li>
+  <li>Enable CONFIG_DISPLAY_MTRRS to verify the MTRR configuration</li>
   <li>
     Implement the .init routine for the
     <a target="_blank" href="SoC/soc.html#ChipOperations">chip operations</a>
@@ -115,6 +116,7 @@
     Implement the
     <a target="_blank" href="SoC/soc.html#MemoryMap">memory map</a>
   </li>
+  <li>coreboot should now attempt to load the payload</li>
 </ol>
 
 
@@ -185,6 +187,20 @@
     <td>coreboot displays the memory map correctly during the BS_WRITE_TABLES state</td>
   </tr>
   <tr>
+    <td>MTRRs</td>
+    <td>
+      Set values: src/drivers/intel/fsp1_1/stack.c/<a target="_blank" href="https://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/drivers/intel/fsp1_1/stack.c;hb=HEAD#l42">setup_stack_and_mtrrs</a><br>
+      Load values: src/drivers/intel/fsp1_1/<a target="_blank" href="https://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/drivers/intel/fsp1_1/after_raminit.S;hb=HEAD#l71">after_raminit.S</a>
+    </td>
+    <td>Set: Post code 0x91
+      (<a target="_blank" href="https://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/include/console/post_codes.h;hb=HEAD#l213">POST_FSP_TEMP_RAM_EXIT</a>)
+      is displayed by
+      <a target="_blank" href="https://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/drivers/intel/fsp1_1/after_raminit.S;hb=HEAD#l41">after_raminit.S</a><br>
+      Load: Post code 0x3C is displayed by
+      <a target="_blank" href="https://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/drivers/intel/fsp1_1/after_raminit.S;hb=HEAD#l152">after_raminit.S</a><br>
+      and CONFIG_DISPLAY_MTRRS=y displays the correct memory regions</td>
+  </tr>
+  <tr>
     <td>PCI Device Support</td>
     <td>Implement a PCI <a target="_blank" href="SoC/soc.html#DeviceDrivers">device driver</a></td>
     <td>The device is detected by coreboot and usable by the payload</td>



More information about the coreboot-gerrit mailing list