[coreboot-gerrit] New patch to review for coreboot: storm: Fix compilation error

Furquan Shaikh (furquan@google.com) gerrit at coreboot.org
Wed Mar 30 01:52:18 CEST 2016


Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14185

-gerrit

commit 89dd1932ed211e0fa88ed4fe47801a5639dce72c
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Mar 29 16:48:04 2016 -0700

    storm: Fix compilation error
    
    Somehow the missing header file in
    https://review.coreboot.org/#/c/14182 did not trigger compilation
    errors before. Add the required header file to enable proper
    compilation of storm.
    
    Change-Id: I83c8f2b5fc41e38c1385ff405370753e6eba2abc
    Signed-off-by: Furquan Shaikh <furquan at google.com>
---
 3rdparty/blobs                   | 2 +-
 src/mainboard/google/storm/mmu.c | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/3rdparty/blobs b/3rdparty/blobs
index b0eeddd..832bc6f 160000
--- a/3rdparty/blobs
+++ b/3rdparty/blobs
@@ -1 +1 @@
-Subproject commit b0eeddd4f5c583818e66521f2552cd3448b357b2
+Subproject commit 832bc6f1f8ffafc5ff397fd95616fdae988f224f
diff --git a/src/mainboard/google/storm/mmu.c b/src/mainboard/google/storm/mmu.c
index fcea8e2..da15795 100644
--- a/src/mainboard/google/storm/mmu.c
+++ b/src/mainboard/google/storm/mmu.c
@@ -11,6 +11,8 @@
  */
 
 #include <arch/cache.h>
+#include <rules.h>
+#include <soc/soc_services.h>
 #include <symbols.h>
 #include "mmu.h"
 
@@ -34,8 +36,10 @@ void setup_dram_mappings(enum dram_state dram)
 		mmu_config_range(DRAM_START, DRAM_SIZE, DCACHE_WRITEBACK);
 		/* Map DMA memory */
 		mmu_config_range(DMA_START, DMA_SIZE, DCACHE_OFF);
+#if ENV_ROMSTAGE
 		/* Mark cbmem backing store as ready. */
 		ipq_cbmem_backing_store_ready();
+#endif
 	} else {
 		mmu_disable_range(DRAM_START, DRAM_SIZE);
 		/* Map DMA memory */



More information about the coreboot-gerrit mailing list