[coreboot-gerrit] Patch set updated for coreboot: intel/gma: Fix VBT generation

Patrick Rudolph (siro@das-labor.org) gerrit at coreboot.org
Thu Mar 31 12:22:30 CEST 2016


Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14188

-gerrit

commit 6ea9ee72d6f85001ec52a844a4105580c064f9e7
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Wed Mar 30 17:59:09 2016 +0200

    intel/gma: Fix VBT generation
    
    The log shows the following error on systems that use the
    native gfx init. The error isn't shown using the VBIOS blob:
    GET_VBIOS: aa55 8086 0 3 0
    VBIOS not found.
    
    Don't shift the class-code, as it's already shifted by the PCI layer.
    
    Tested-on: x220
    Tested-by: Alexander Couzens <lynxis at fe80.eu>
    
    Change-Id: I69018940dd51966b45774e0576a1380f90716dce
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/drivers/intel/gma/vbt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index 1993793..e768402 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -93,9 +93,9 @@ generate_fake_intel_oprom(const struct i915_gpu_controller_info *conf,
 		pcir->device = dev->device;
 		pcir->length = sizeof(*pcir);
 		pcir->revision = dev->class;
-		pcir->classcode[0] = dev->class >> 8;
-		pcir->classcode[1] = dev->class >> 16;
-		pcir->classcode[2] = dev->class >> 24;
+		pcir->classcode[0] = dev->class;
+		pcir->classcode[1] = dev->class >> 8;
+		pcir->classcode[2] = dev->class >> 16;
 		pcir->indicator = 0x80;
 
 		vbt_size = generate_vbt (conf, (void *)(PCI_VGA_RAM_IMAGE_START + 0x80), idstr);



More information about the coreboot-gerrit mailing list