[coreboot-gerrit] New patch to review for coreboot: HobLib: Don't break GCC strict aliasing
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Thu May 5 03:04:38 CEST 2016
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14622
-gerrit
commit acdfd1e3b9ebbffbdd919731290c5cbf7b6e5388
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date: Wed May 4 17:57:52 2016 -0700
HobLib: Don't break GCC strict aliasing
Change-Id: I1bd33e423b0fcb69597e001b61c6ea916f5fe44a
Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
.../intel/edk2/uefi_2.4/MdePkg/Include/Library/HobLib.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/vendorcode/intel/edk2/uefi_2.4/MdePkg/Include/Library/HobLib.h b/src/vendorcode/intel/edk2/uefi_2.4/MdePkg/Include/Library/HobLib.h
index 2cc4b1b..ea95b5c 100644
--- a/src/vendorcode/intel/edk2/uefi_2.4/MdePkg/Include/Library/HobLib.h
+++ b/src/vendorcode/intel/edk2/uefi_2.4/MdePkg/Include/Library/HobLib.h
@@ -431,7 +431,7 @@ BuildMemoryAllocationHob (
**/
#define GET_HOB_TYPE(HobStart) \
- ((*(EFI_HOB_GENERIC_HEADER **)&(HobStart))->HobType)
+ (((EFI_HOB_GENERIC_HEADER *)HobStart)->HobType)
/**
Returns the length, in bytes, of a HOB.
@@ -445,7 +445,7 @@ BuildMemoryAllocationHob (
**/
#define GET_HOB_LENGTH(HobStart) \
- ((*(EFI_HOB_GENERIC_HEADER **)&(HobStart))->HobLength)
+ (((EFI_HOB_GENERIC_HEADER *)HobStart)->HobLength)
/**
Returns a pointer to the next HOB in the HOB list.
@@ -459,7 +459,7 @@ BuildMemoryAllocationHob (
**/
#define GET_NEXT_HOB(HobStart) \
- (VOID *)(*(UINT8 **)&(HobStart) + GET_HOB_LENGTH (HobStart))
+ (VOID *)((UINT8 *)(HobStart) + GET_HOB_LENGTH(HobStart))
/**
Determines if a HOB is the last HOB in the HOB list.
@@ -488,7 +488,7 @@ BuildMemoryAllocationHob (
**/
#define GET_GUID_HOB_DATA(HobStart) \
- (VOID *)(*(UINT8 **)&(HobStart) + sizeof (EFI_HOB_GUID_TYPE))
+ (VOID *)((UINT8 *)(HobStart) + sizeof(EFI_HOB_GUID_TYPE))
/**
Returns the size of the data buffer from a HOB of type EFI_HOB_TYPE_GUID_EXTENSION.
@@ -501,6 +501,6 @@ BuildMemoryAllocationHob (
@return The size of the data buffer.
**/
#define GET_GUID_HOB_DATA_SIZE(HobStart) \
- (UINT16)(GET_HOB_LENGTH (HobStart) - sizeof (EFI_HOB_GUID_TYPE))
+ (UINT16)(GET_HOB_LENGTH(HobStart) - sizeof(EFI_HOB_GUID_TYPE))
#endif
More information about the coreboot-gerrit
mailing list