[coreboot-gerrit] Patch set updated for coreboot: samsung/stumpy: fix power LED operation
Matt DeVillier (matt.devillier@gmail.com)
gerrit at coreboot.org
Tue Nov 8 15:54:29 CET 2016
Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17266
-gerrit
commit 6926ba65100a8ee9f62386f980c286ee61ea8488
Author: Matt DeVillier <matt.devillier at gmail.com>
Date: Mon Nov 7 16:43:03 2016 -0600
samsung/stumpy: fix power LED operation
commit 80EF7B7 [IT8772F: Clean up it8772f includes and add a LED API]
broke power LED operation when it incorrectly transferred
values from the old function (it8772f_gpio_setup) to the new one (
it8772f_gpio_led). Restore the correct values so power LED illuminates
when powered on.
Change-Id: I99a38351bb52063fafa7436e6397a8da7fc1e952
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
src/mainboard/samsung/stumpy/romstage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/samsung/stumpy/romstage.c b/src/mainboard/samsung/stumpy/romstage.c
index 1062b64..b2b21c4 100644
--- a/src/mainboard/samsung/stumpy/romstage.c
+++ b/src/mainboard/samsung/stumpy/romstage.c
@@ -144,8 +144,8 @@ static void setup_sio_gpios(void)
/*
* GPIO45 as LED_POWER#
*/
- it8772f_gpio_led(DUMMY_DEV, 4 /* set */, (0x1 << 5) /* select */,
- 0x00 /* polarity: non-inverting */, 0x00 /* 0 = pulldown */,
+ it8772f_gpio_led(GPIO_DEV, 4 /* set */, (0x1 << 5) /* select */,
+ (0x1 << 5) /* polarity */, (0x1 << 5) /* 1 = pullup */,
(0x1 << 5) /* output */, (0x1 << 5) /* 1 = Simple IO function */,
SIO_GPIO_BLINK_GPIO45, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
More information about the coreboot-gerrit
mailing list