[coreboot-gerrit] Patch merged into coreboot/master: rockchip/rk3399: Change PLL configuration to match Linux kernel

gerrit at coreboot.org gerrit at coreboot.org
Thu Nov 17 17:59:13 CET 2016


the following patch was just integrated into master:
commit 8e42bd1cbcf8edad69fac402b43cd8740c0ad870
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Nov 1 15:24:54 2016 -0700

    rockchip/rk3399: Change PLL configuration to match Linux kernel
    
    The Kevin project has been too smooth and boring for our tastes in the
    last last few weeks, so we've decided to stir the pot a little bit and
    reshuffle all our PLL settings at the last minute. The new settings
    match exactly what the Linux kernel expects on boot, so it doesn't need
    to reinitialize anything and risk a glitch.
    
    Naturally, changing PLL rates will affect child clocks, so this patch
    changes vop_aclk (192MHz -> 200MHz, 400MHz in the kernel), pmu_pclk
    (99MHz -> 96.57MHz) and i2c0_src (198MHz -> 338MHz, leading to an
    effective I2C0 change 399193Hz -> 398584Hz).
    
    BRANCH=gru
    BUG=chrome-os-partner:59139
    TEST=Booted Kevin, sanity checking display and beep. Instrumented
    rockchip_rk3399_pll_set_params() in the kernel and confirmed that GPLL,
    PPLL and CPLL do not get reinitialized anymore (with additional kernel
    patch to ignore frac divider when it's not used). Also confirmed that
    /sys/kernel/debug/clk_summary now shows pclk_pmu_src 96571429 because
    the kernel doesn't even bother to reinitialize the divisor.
    
    Change-Id: Ib44d872a7b7f177fb2e60ccc6992f888835365eb
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 9b82056037be5a5aebf146784ffb246780013c96
    Original-Change-Id: Ie112104035b01166217a8c5b5586972b4d7ca6ec
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/405785
    Original-Commit-Ready: Xing Zheng <zhengxing at rock-chips.com>
    Original-Tested-by: Xing Zheng <zhengxing at rock-chips.com>
    Original-Reviewed-by: Xing Zheng <zhengxing at rock-chips.com>
    Original-Reviewed-by: Douglas Anderson <dianders at chromium.org>
    Reviewed-on: https://review.coreboot.org/17378
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/17378 for details.

-gerrit



More information about the coreboot-gerrit mailing list