[coreboot-gerrit] New patch to review for coreboot: google/reef: Fix config options for TPM

Furquan Shaikh (furquan@google.com) gerrit at coreboot.org
Sat Oct 1 03:45:34 CEST 2016


Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16841

-gerrit

commit 868aa38291ae8fbab6ba163cde8c132eaf0ff879
Author: Furquan Shaikh <furquan at chromium.org>
Date:   Fri Sep 30 18:43:41 2016 -0700

    google/reef: Fix config options for TPM
    
    Use "default" keyword for TPM config options so that the correct value is
    picked up.
    
    BUG=chrome-os-partner:58049
    BRANCH=None
    TEST=Verified that the config option values are right in generated
    coreboot config.
    
    Change-Id: Iea0b0d4befeca381645b172e013c7795b649167a
    Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
 src/mainboard/google/reef/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index 5039725..08ba097 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -20,13 +20,13 @@ config BASEBOARD_REEF_LAPTOP
 	select SYSTEM_TYPE_LAPTOP
 
 config DRIVER_TPM_I2C_BUS
-	hex "0x2"
+	default "0x2"
 
 config DRIVER_TPM_I2C_ADDR
-	hex "0x50"
+	default "0x50"
 
 config DRIVER_TPM_I2C_IRQ
-	int "60" # GPE0_DW1_28
+	default "60" # GPE0_DW1_28
 
 config CHROMEOS
 	select LID_SWITCH if BASEBOARD_REEF_LAPTOP



More information about the coreboot-gerrit mailing list