[coreboot-gerrit] New patch to review for coreboot: samsung/lumpy: Swap SPD assignments

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sat Oct 1 13:43:42 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16845

-gerrit

commit 9c9378d56aaf677613d8032ad31ff886ba48e6bf
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Oct 1 12:54:01 2016 +0300

    samsung/lumpy: Swap SPD assignments
    
    On-board memory is on channel 1.
    This fixes native raminit with 4GiB SO-DIMM installed.
    
    Change-Id: If1b94e050d7e8d0dbd349c0415a182730aa5fa90
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/samsung/lumpy/romstage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c
index 918c73a..93f2059 100644
--- a/src/mainboard/samsung/lumpy/romstage.c
+++ b/src/mainboard/samsung/lumpy/romstage.c
@@ -239,9 +239,9 @@ const struct southbridge_usb_port mainboard_usb_ports[] = {
 void mainboard_get_spd(spd_raw_data *spd)
 {
 	/* get onboard dimm spd */
-	memcpy(&spd[0], locate_spd(), 256);
+	memcpy(&spd[2], locate_spd(), 256);
 	/* read removable dimm spd */
-	read_spd(&spd[2], 0x50);
+	read_spd(&spd[0], 0x50);
 }
 
 void mainboard_early_init(int s3resume)



More information about the coreboot-gerrit mailing list