[coreboot-gerrit] Patch set updated for coreboot: src/drivers: Remove whitespace after sizeof

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Oct 3 23:14:24 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16867

-gerrit

commit 99a1cd412add757051c5f594c43b28c10fddc118
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Mon Oct 3 22:29:04 2016 +0200

    src/drivers: Remove whitespace after sizeof
    
    Change-Id: Ifd8477966feb744fb30cae7fd62e3783092c9d34
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/drivers/i2c/at24rf08c/lenovo_serials.c | 18 +++++++++---------
 src/drivers/intel/gma/vbt.c                | 18 +++++++++---------
 src/drivers/usb/ehci_debug.c               |  4 ++--
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c
index 881bf53..1b5e4ba 100644
--- a/src/drivers/i2c/at24rf08c/lenovo_serials.c
+++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c
@@ -59,7 +59,7 @@ static void at24rf08c_read_string_dev(struct device *dev, u8 start,
 		int t = at24rf08c_read_byte(dev, start + i);
 
 		if (t < 0x20 || t > 0x7f) {
-			memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+			memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
 			return;
 		}
 		result[i] = t;
@@ -74,7 +74,7 @@ static void at24rf08c_read_string(u8 bank, u8 start, u8 len, char *result)
 	dev = at24rf08c_find_bank(bank);
 	if (dev == NULL) {
 		printk(BIOS_WARNING, "EEPROM not found\n");
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
 		return;
 	}
 
@@ -89,7 +89,7 @@ const char *smbios_mainboard_serial_number(void)
 	if (already_read)
 		return result;
 
-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));
 	at24rf08c_read_string(0, 0x2e, 7, result);
 
 	already_read = 1;
@@ -104,7 +104,7 @@ const char *lenovo_mainboard_partnumber(void)
 	if (already_read)
 		return result;
 
-	memset (result, 0, sizeof (result));
+	memset (result, 0, sizeof(result));
 	at24rf08c_read_string(0, 0x27, 7, result);
 
 	already_read = 1;
@@ -133,7 +133,7 @@ void smbios_mainboard_set_uuid(u8 *uuid)
 		return;
 	}
 
-	memset (result, 0, sizeof (result));
+	memset (result, 0, sizeof(result));
 
 	dev = dev_find_slot_on_smbus(1, 0x56);
 	if (dev == NULL) {
@@ -155,7 +155,7 @@ void smbios_mainboard_set_uuid(u8 *uuid)
 				break;
 		}
 		if (t < 0) {
-			memset (result, 0, sizeof (result));
+			memset (result, 0, sizeof(result));
 			break;
 		}
 		result[remap[i]] = t;
@@ -176,17 +176,17 @@ const char *smbios_mainboard_version(void)
 	if (already_read)
 		return result;
 
-	memset (result, 0, sizeof (result));
+	memset (result, 0, sizeof(result));
 
 	dev = at24rf08c_find_bank(2);
 	if (dev == NULL) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
 		return result;
 	}
 
 	len = at24rf08c_read_byte(dev, 0x26) - 2;
 	if (len < 0 || len > sizeof(result) - 1) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
 		return result;
 	}
 
diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index 9ec09d3..4a7c9c7 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -32,30 +32,30 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf,
 	struct bdb_general_features *genfeat;
 	u8 *ptr;
 
-	memset (head, 0, sizeof (*head));
+	memset (head, 0, sizeof(*head));
 
 	memset(head->signature, ' ', sizeof(head->signature));
 	memcpy(head->signature, idstr, MIN(strlen(idstr),
 						sizeof(head->signature)));
 	head->version = 100;
-	head->header_size = sizeof (*head);
-	head->bdb_offset = sizeof (*head);
+	head->header_size = sizeof(*head);
+	head->bdb_offset = sizeof(*head);
 
 	bdb_head = (struct bdb_header *) (head + 1);
-	memset (bdb_head, 0, sizeof (*bdb_head));
+	memset (bdb_head, 0, sizeof(*bdb_head));
 	memcpy (bdb_head->signature, "BIOS_DATA_BLOCK ", 16);
 	bdb_head->version = 0xa8;
-	bdb_head->header_size = sizeof (*bdb_head);
+	bdb_head->header_size = sizeof(*bdb_head);
 
 	ptr = (u8 *) (bdb_head + 1);
 
 	ptr[0] = BDB_GENERAL_FEATURES;
-	ptr[1] = sizeof (*genfeat);
-	ptr[2] = sizeof (*genfeat) >> 8;
+	ptr[1] = sizeof(*genfeat);
+	ptr[2] = sizeof(*genfeat) >> 8;
 	ptr += 3;
 
 	genfeat = (struct bdb_general_features *) ptr;
-	memset (genfeat, 0, sizeof (*genfeat));
+	memset (genfeat, 0, sizeof(*genfeat));
 	genfeat->panel_fitting = 3;
 	genfeat->flexaim = 1;
 	genfeat->download_ext_vbt = 1;
@@ -66,7 +66,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf,
 	genfeat->int_crt_support = 1;
 	genfeat->dp_ssc_enb = 1;
 
-	ptr += sizeof (*genfeat);
+	ptr += sizeof(*genfeat);
 
 	bdb_head->bdb_size = ptr - (u8 *)bdb_head;
 	head->vbt_size = ptr - (u8 *)head;
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c
index cac043e..84e2c66 100644
--- a/src/drivers/usb/ehci_debug.c
+++ b/src/drivers/usb/ehci_debug.c
@@ -427,7 +427,7 @@ static int usbdebug_init_(unsigned ehci_bar, unsigned offset, struct ehci_debug_
 	int playtimes = 3;
 
 	/* Keep all endpoints disabled before any printk() call. */
-	memset(info, 0, sizeof (*info));
+	memset(info, 0, sizeof(*info));
 	info->ehci_base = (void *)ehci_bar;
 	info->ehci_debug = (void *)(ehci_bar + offset);
 
@@ -659,7 +659,7 @@ static int get_usbdebug_from_cbmem(struct ehci_debug_info *info)
 	if (dbg_info_cbmem == NULL)
 		return -1;
 
-	memcpy(info, dbg_info_cbmem, sizeof (*info));
+	memcpy(info, dbg_info_cbmem, sizeof(*info));
 	printk(BIOS_DEBUG, "EHCI debug port found in CBMEM.\n");
 
 	return 0;



More information about the coreboot-gerrit mailing list