[coreboot-gerrit] Patch merged into coreboot/master: rockchip: Remove pulls for gpio_output(), clean up code

gerrit at coreboot.org gerrit at coreboot.org
Tue Oct 4 21:17:46 CEST 2016


the following patch was just integrated into master:
commit 2768a119ce08893975f3bf6788fd31c7071e7c9a
Author: Julius Werner <jwerner at chromium.org>
Date:   Thu Sep 1 22:55:58 2016 -0700

    rockchip: Remove pulls for gpio_output(), clean up code
    
    Output GPIOs should never have a pull-up or pull-down resistor attached
    since they're actively driven. Since some GPIOs get initialized with a
    pull at power-on reset, we should explicitly overwrite that setting.
    Most other platforms do this on gpio_output, but Rockchip hadn't yet.
    
    Also, shuffle some code around to make things cleaner and allow for
    easier code reuse.
    
    BRANCH=None
    BUG=chrome-os-partner:52526
    TEST=Booted Kevin.
    
    Change-Id: I1425d074ea1e90f4484e1e84a8002b057192c5f7
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: df5b236bfd58b172435043c1cb792b917a4ec4ab
    Original-Change-Id: I044266d71ef8bd0518316ff72d829d1ca1e30f35
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/382531
    Original-Reviewed-by: Simon Glass <sjg at google.com>
    Reviewed-on: https://review.coreboot.org/16710
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/16710 for details.

-gerrit



More information about the coreboot-gerrit mailing list