[coreboot-gerrit] Patch set updated for coreboot: rockchip/rk3399: dram: improve dram stability when run high frequency

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16722

-gerrit

commit e2d4588220d85dd61f0a6812d81e5bbfba93992a
Author: Lin Huang <hl at rock-chips.com>
Date:   Wed Sep 21 18:19:24 2016 +0800

    rockchip/rk3399: dram: improve dram stability when run high frequency
    
    there are two modify in the driver:
    1. correctly set speeds base on DDR frequency.
       Controls the speeds in the predriver circuits to reduce power.
       SPEED[1:0]
       2'b00:less than 800Mbps(400MHz)
       2b01 : 800Mbps(400MHz) to 1600Mbps(800MHz)
       2b10 : 1600Mbsp(800MHz) to 2400Mbps(1200MHz)
       2b11 : 3200Mbps and greater
    2. config the number of cycles phy clock pll wait time after
       locking base on ddr config file.
    
    BRANCH=none
    BUG=chrome-os-partner:56940
    TEST=do memtester on kevin board, and pass
    
    Change-Id: Iaf6da59c6c5c290867e0922a2a99de272f4c7bde
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 125cf8afac3a682d33896fe74a20ba1d498a3bd2
    Original-Change-Id: Iabc17df37a701c4f052540c3c259f209a1db3c59
    Original-Signed-off-by: Lin Huang <hl at rock-chips.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/387428
    Original-Reviewed-by: Douglas Anderson <dianders at chromium.org>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/soc/rockchip/rk3399/sdram.c | 35 ++++++++++++++++++++++++-----------
 1 file changed, 24 insertions(+), 11 deletions(-)

diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c
index 9211895..1021c6b 100644
--- a/src/soc/rockchip/rk3399/sdram.c
+++ b/src/soc/rockchip/rk3399/sdram.c
@@ -322,6 +322,7 @@ static void phy_io_config(u32 channel,
 	u32 mode_sel = 0;
 	u32 reg_value;
 	u32 drv_value, odt_value;
+	u32 speed;
 
 	/* vref setting */
 	if (sdram_params->dramtype == LPDDR4) {
@@ -436,22 +437,33 @@ static void phy_io_config(u32 channel,
 	/* PHY_939 PHY_PAD_CS_DRIVE */
 	clrsetbits_le32(&denali_phy[939], 0x7 << 14, mode_sel << 14);
 
+
+	/* speed setting */
+	if (sdram_params->ddr_freq < 400*MHz)
+		speed = 0x0;
+	else if (sdram_params->ddr_freq < 800*MHz)
+		speed = 0x1;
+	else if (sdram_params->ddr_freq < 1200*MHz)
+		speed = 0x2;
+	else
+		speed = 0x3;
+
 	/* PHY_924 PHY_PAD_FDBK_DRIVE */
-	clrsetbits_le32(&denali_phy[924], 0x3 << 21, mode_sel << 21);
+	clrsetbits_le32(&denali_phy[924], 0x3 << 21, speed << 21);
 	/* PHY_926 PHY_PAD_DATA_DRIVE */
-	clrsetbits_le32(&denali_phy[926], 0x3 << 9, mode_sel << 9);
+	clrsetbits_le32(&denali_phy[926], 0x3 << 9, speed << 9);
 	/* PHY_927 PHY_PAD_DQS_DRIVE */
-	clrsetbits_le32(&denali_phy[927], 0x3 << 9, mode_sel << 9);
+	clrsetbits_le32(&denali_phy[927], 0x3 << 9, speed << 9);
 	/* PHY_928 PHY_PAD_ADDR_DRIVE */
-	clrsetbits_le32(&denali_phy[928], 0x3 << 17, mode_sel << 17);
+	clrsetbits_le32(&denali_phy[928], 0x3 << 17, speed << 17);
 	/* PHY_929 PHY_PAD_CLK_DRIVE */
-	clrsetbits_le32(&denali_phy[929], 0x3 << 17, mode_sel << 17);
+	clrsetbits_le32(&denali_phy[929], 0x3 << 17, speed << 17);
 	/* PHY_935 PHY_PAD_CKE_DRIVE */
-	clrsetbits_le32(&denali_phy[935], 0x3 << 17, mode_sel << 17);
+	clrsetbits_le32(&denali_phy[935], 0x3 << 17, speed << 17);
 	/* PHY_937 PHY_PAD_RST_DRIVE */
-	clrsetbits_le32(&denali_phy[937], 0x3 << 17, mode_sel << 17);
+	clrsetbits_le32(&denali_phy[937], 0x3 << 17, speed << 17);
 	/* PHY_939 PHY_PAD_CS_DRIVE */
-	clrsetbits_le32(&denali_phy[939], 0x3 << 17, mode_sel << 17);
+	clrsetbits_le32(&denali_phy[939], 0x3 << 17, speed << 17);
 }
 
 static void pctl_cfg(u32 channel,
@@ -477,9 +489,10 @@ static void pctl_cfg(u32 channel,
 	/* rank count need to set for init */
 	set_memory_map(channel, sdram_params);
 
-	write32(&denali_phy[910], 0x6400);
-	write32(&denali_phy[911], 0x01221102);
-	write32(&denali_phy[912], 0x0);
+	write32(&denali_phy[910], sdram_params->phy_regs.denali_phy[910]);
+	write32(&denali_phy[911], sdram_params->phy_regs.denali_phy[911]);
+	write32(&denali_phy[912], sdram_params->phy_regs.denali_phy[912]);
+
 	pwrup_srefresh_exit = read32(&denali_ctl[68]) & PWRUP_SREFRESH_EXIT;
 	clrbits_le32(&denali_ctl[68], PWRUP_SREFRESH_EXIT);