[coreboot-gerrit] Patch set updated for coreboot: i2c/ww_ring: LED changes as per UX team feedback.

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Oct 4 21:43:47 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16718

-gerrit

commit 878d0ea0dfc95979e3472176a118ee253652c9c9
Author: Suresh Rajashekara <sureshraj at google.com>
Date:   Mon Sep 19 17:43:25 2016 -0700

    i2c/ww_ring: LED changes as per UX team feedback.
    
    Colors and patterns as defined by the UX team
    
    BUG=b:31501528
    TEST=Move the device to different states in FW using rec and dev
    button and verify the colors
    BRANCH=None
    
    Change-Id: I66d41a54590cd3ce4e5202c7cfa890f462fe195e
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 703559d5dddaeeb7d435d6cadbb2009a1b7a76c8
    Original-Change-Id: I95ab1fa59b483396ff1498a28f1ee98ac08d02d7
    Original-Signed-off-by: Suresh Rajashekara <sureshraj at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/387258
    Original-Commit-Ready: Suresh Rajashekara <sureshraj at chromium.org>
    Original-Tested-by: Suresh Rajashekara <sureshraj at chromium.org>
    Original-Reviewed-by: Christopher Book <cbook at chromium.org>
    Original-Reviewed-by: Kan Yan <kyan at google.com>
---
 src/drivers/i2c/ww_ring/ww_ring_programs.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/drivers/i2c/ww_ring/ww_ring_programs.c b/src/drivers/i2c/ww_ring/ww_ring_programs.c
index 5b0c8a8..fb74a1b 100644
--- a/src/drivers/i2c/ww_ring/ww_ring_programs.c
+++ b/src/drivers/i2c/ww_ring/ww_ring_programs.c
@@ -125,13 +125,13 @@ row_blue:  dw 0000000000000100b
 	ld rb, 2   # LED off duration
 	mux_map_addr row_red
 loop:
-	ld rc, 180	; red intensity
+	ld rc, 1        ; red intensity
 	set_pwm rc
 	mux_map_addr row_green
-	ld rc, 80	; green intensity
+	ld rc, 50       ; green intensity
 	set_pwm rc
 	mux_map_addr row_blue
-	ld rc, 0	; blue intensity
+	ld rc, 155      ; blue intensity
 	set_pwm rc
 wait1:
 	wait 0.1
@@ -152,9 +152,9 @@ wait2:
 */
 static const uint8_t blink_wipeout1_text[] = {
 	0x00,  0x01,  0x00,  0x02,  0x00,  0x04,  0x90,  0x02,
-	0x94,  0x02,  0x9f,  0x80,  0x98,   180,  0x84,  0x62,
-	0x9f,  0x81,  0x98,    80,  0x84,  0x62,  0x9f,  0x82,
-	0x98,     0,  0x84,  0x62,  0x4c,  0x00,  0x86,  0x2c,
+	0x94,  0x02,  0x9f,  0x80,  0x98,     1,  0x84,  0x62,
+	0x9f,  0x81,  0x98,    50,  0x84,  0x62,  0x9f,  0x82,
+	0x98,   155,  0x84,  0x62,  0x4c,  0x00,  0x86,  0x2c,
 	0x40,  0x00,  0x9f,  0x81,  0x40,  0x00,  0x9f,  0x80,
 	0x40,  0x00,  0x4c,  0x00,  0x86,  0x49,  0xa0,  0x03,
 	0xc0,  0x00,  0xc0,  0x00,  0x00,
@@ -205,7 +205,7 @@ static const TiLp55231Program blink_recovery1_program = {
 	mux_map_addr row_blue
 	set_pwm 0h
  loop3: trigger w{1}
-	ramp 2, 255
+	ramp 2, 155
 	end
 */
 
@@ -213,7 +213,7 @@ static const uint8_t fade_in1_text[] = {
 	0x00,  0x01,  0x00,  0x02,  0x00,  0x04,  0x9f,  0x80,
 	0x40,  0x01,  0xe0,  0x0c,  0xc0,  0x00,  0x9f,  0x81,
 	0x40,  0x00,  0xe0,  0x80,  0x46,  0x32,  0xc0,  0x00,
-	0x9f,  0x82,  0x40,  0x00,  0xe0,  0x80,  0x20,  0xff,
+	0x9f,  0x82,  0x40,  0x00,  0xe0,  0x80,  0x34,  0x9B,
 	0xc0,  0x00,  0x00,
 };
 static const TiLp55231Program fade_in1_program = {



More information about the coreboot-gerrit mailing list