[coreboot-gerrit] New patch to review for coreboot: soc/intel/fsp_broadwell_de: Remove the enforced fsp1.0 APIs call sequence

York Yang (york.yang@intel.com) gerrit at coreboot.org
Wed Oct 5 19:01:20 CEST 2016


York Yang (york.yang at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16892

-gerrit

commit 0245a5a7e3911e0fad0fcaae9a02ade61cb2a98f
Author: York Yang <york.yang at intel.com>
Date:   Wed Oct 5 09:32:46 2016 -0700

    soc/intel/fsp_broadwell_de: Remove the enforced fsp1.0 APIs call sequence
    
    The enforced FSP 1.0 APIs call was used to workaround a fsp1.0 driver issue.
    As the issue has been fixed in fsp1.0 driver, need to remove the enforced
    workaround. Otherwise will see error message 'FSP API NotifyPhase failed' in
    serial log.
    
    Verified on Intel Camelback Mountain CRB and confirmed that the serial log error
    message regarding the 'FSP API NotifyPhase failed' is gone.
    
    Change-Id: Iafa1d22e2476769fd841a3ebaa1ab4f9713c6c39
    Signed-off-by: York Yang <york.yang at intel.com>
---
 src/soc/intel/fsp_broadwell_de/chip.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/src/soc/intel/fsp_broadwell_de/chip.c b/src/soc/intel/fsp_broadwell_de/chip.c
index 78649fc..b8db395 100644
--- a/src/soc/intel/fsp_broadwell_de/chip.c
+++ b/src/soc/intel/fsp_broadwell_de/chip.c
@@ -66,21 +66,9 @@ static void enable_dev(device_t dev)
 	}
 }
 
-static void fsp_notify(void *arg)
-{
-	FspNotify (*(uint32_t *)arg);
-}
-
-static uint32_t gFspNotifyAfterPciEnumeration = EnumInitPhaseAfterPciEnumeration;
-static uint32_t gFspNotifyReadtToBoot         = EnumInitPhaseReadyToBoot;
-static BOOT_STATE_CALLBACK(bscb_fspnotify1, fsp_notify, &gFspNotifyAfterPciEnumeration);
-static BOOT_STATE_CALLBACK(bscb_fspnotify2, fsp_notify, &gFspNotifyReadtToBoot);
-
 /* Called at BS_DEV_INIT_CHIPS time -- very early. Just after BS_PRE_DEVICE. */
 static void soc_init(void *chip_info)
 {
-	boot_state_sched_on_exit(&bscb_fspnotify1, BS_DEV_RESOURCES);
-	boot_state_sched_on_exit(&bscb_fspnotify2, BS_PAYLOAD_LOAD);
 	broadwell_de_init_pre_device();
 }
 



More information about the coreboot-gerrit mailing list