[coreboot-gerrit] New patch to review for coreboot: mainboard/artecgroup: Use C89 comments style & remove commented code
HAOUAS Elyes (ehaouas@noos.fr)
gerrit at coreboot.org
Fri Oct 7 17:40:35 CEST 2016
HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16923
-gerrit
commit 2d217900c9229fef5f02d37b9798ce3ef76b5c81
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date: Fri Oct 7 17:38:01 2016 +0200
mainboard/artecgroup: Use C89 comments style & remove commented code
Change-Id: Ia1e7f558bbc44001358339a522e59a2ef7c420fb
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
src/mainboard/artecgroup/dbe61/mainboard.c | 2 +-
src/mainboard/artecgroup/dbe61/romstage.c | 12 ------------
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/src/mainboard/artecgroup/dbe61/mainboard.c b/src/mainboard/artecgroup/dbe61/mainboard.c
index b98c711..179fab7 100644
--- a/src/mainboard/artecgroup/dbe61/mainboard.c
+++ b/src/mainboard/artecgroup/dbe61/mainboard.c
@@ -34,7 +34,7 @@ static void init_gpio(void)
static void init(struct device *dev)
{
- // BOARD-SPECIFIC INIT
+ /* BOARD-SPECIFIC INIT */
printk(BIOS_DEBUG, "ARTECGROUP DBE61 ENTER %s\n", __func__);
init_gpio();
diff --git a/src/mainboard/artecgroup/dbe61/romstage.c b/src/mainboard/artecgroup/dbe61/romstage.c
index b0bfc5b..7cf902e 100644
--- a/src/mainboard/artecgroup/dbe61/romstage.c
+++ b/src/mainboard/artecgroup/dbe61/romstage.c
@@ -87,16 +87,4 @@ void main(unsigned long bist)
cpuRegInit(0, DIMM0, DIMM1, DRAM_TERMINATED);
sdram_initialize(1, memctrl);
-
- /* Dump memory configuration. */
-#if 0
- msr = rdmsr(MC_CF07_DATA);
- printk(BIOS_DEBUG, "MC_CF07_DATA: %08x value is: %08x:%08x\n", MC_CF07_DATA, msr.hi, msr.lo);
-
- msr = rdmsr(MC_CF1017_DATA);
- printk(BIOS_DEBUG, "MC_CF1017_DATA: %08x value is: %08x:%08x\n", MC_CF07_DATA, msr.hi, msr.lo);
-
- msr = rdmsr(MC_CF8F_DATA);
- printk(BIOS_DEBUG, "MC_CF8F_DATA: %08x value is: %08x:%08x\n", MC_CF07_DATA, msr.hi, msr.lo);
-#endif
}
More information about the coreboot-gerrit
mailing list