[coreboot-gerrit] New patch to review for coreboot: [WIP] google/reef: update timing of sdmode toggling
Sathyanarayana Nujella (sathyanarayana.nujella@intel.com)
gerrit at coreboot.org
Fri Oct 7 21:01:35 CEST 2016
Sathyanarayana Nujella (sathyanarayana.nujella at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16933
-gerrit
commit f123ac2b9f2094f0f97e4c196ddc4ed54a28075a
Author: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Date: Fri Oct 7 11:27:10 2016 -0700
[WIP] google/reef: update timing of sdmode toggling
Maxim98357a speaker amp requires BCLK & SFRM to be active
and stable before it is unmuted. If there is a BLCK and no
SFRM, it results in a pop sound.
sdmode_delay property already exists which facilitates this
configuration. This patch updates "sdmode_delay" to avoid
pop sound.
[To be removed, putting here to detail my issue observed]
If I set this value in devicetree.cb, I am able to see it reflected
in SSDT.dsl, but when I read in kernel device_property_read_u32(),
it is returning an error and hence sdmode_delay is read "0" in kernel side
BUG=None
BRANCH=None
TEST=while audio playback via headset, remove headset.
Audio will be switched playback to speaker. Observe if
pop sound comes from speaker.
Change-Id: I7ad68caa88d7b3ff52ac1379fe6564de27d97777
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
src/mainboard/google/reef/variants/baseboard/devicetree.cb | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
index 43ec2ed..989acd9 100644
--- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
@@ -85,6 +85,7 @@ chip soc/intel/apollolake
device pci 0e.0 on # - Audio
chip drivers/generic/max98357a
register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
+ register "sdmode_delay" = "5"
device generic 0 on end
end
end
More information about the coreboot-gerrit
mailing list