[coreboot-gerrit] Patch set updated for coreboot: mainboard/amd/bettong: Use C89 comments style & remove commented code

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Mon Oct 10 20:23:44 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16907

-gerrit

commit f80e21c9b4a3a88964d2d89cab4349d99519ec68
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Mon Oct 10 20:20:09 2016 +0200

    mainboard/amd/bettong: Use C89 comments style & remove commented code
    
    Change-Id: I137b27ffb0e54a9ca6b0bd3a454b1d99b3e1c22b
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 3rdparty/arm-trusted-firmware            | 2 +-
 src/mainboard/amd/bettong/BiosCallOuts.c | 2 +-
 src/mainboard/amd/bettong/OemCustomize.c | 4 ++--
 src/mainboard/amd/bettong/mptable.c      | 1 -
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware
index bfd9251..a5a4231 160000
--- a/3rdparty/arm-trusted-firmware
+++ b/3rdparty/arm-trusted-firmware
@@ -1 +1 @@
-Subproject commit bfd925139fdbc2e87979849907b34843aa326994
+Subproject commit a5a423100822c4b8c9982024c333460f0d019d82
diff --git a/src/mainboard/amd/bettong/BiosCallOuts.c b/src/mainboard/amd/bettong/BiosCallOuts.c
index d4d4410..a2eeec7 100644
--- a/src/mainboard/amd/bettong/BiosCallOuts.c
+++ b/src/mainboard/amd/bettong/BiosCallOuts.c
@@ -72,7 +72,7 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 	if (StdHeader->Func == AMD_INIT_RESET) {
 		FCH_RESET_DATA_BLOCK *FchParams_reset = (FCH_RESET_DATA_BLOCK *)FchData;
 		printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");
-		//FchParams_reset->EcChannel0 = TRUE; /* logical devicd 3 */
+
 		FchParams_reset->FchReset.Xhci0Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
 		FchParams_reset->FchReset.Xhci1Enable = FALSE;
 		FchParams_reset->EarlyOemGpioTable = oem_bettong_gpio;
diff --git a/src/mainboard/amd/bettong/OemCustomize.c b/src/mainboard/amd/bettong/OemCustomize.c
index 3300244..a32ea9a 100644
--- a/src/mainboard/amd/bettong/OemCustomize.c
+++ b/src/mainboard/amd/bettong/OemCustomize.c
@@ -71,7 +71,7 @@ static const PCIe_PORT_DESCRIPTOR PortList [] = {
 	},
 	/* Initialize Port descriptor (PCIe port, Lanes 0-3, PCI Device Number 2, ...) */
 	{
-		DESCRIPTOR_TERMINATE_LIST, // Descriptor flags  !!!IMPORTANT!!! Terminate last element of array
+		DESCRIPTOR_TERMINATE_LIST, /* Descriptor flags  !!!IMPORTANT!!! Terminate last element of array */
 		PCIE_ENGINE_DATA_INITIALIZER (PciePortEngine, 0, 3),
 		PCIE_PORT_DATA_INITIALIZER_V2 (PortEnabled, ChannelTypeExt6db, 2, 1,
 				HotplugDisabled,
@@ -91,7 +91,7 @@ static const PCIe_DDI_DESCRIPTOR DdiList [] = {
 	},
 	/* DP1 */
 	{
-		0, //DESCRIPTOR_TERMINATE_LIST,
+		0, /*DESCRIPTOR_TERMINATE_LIST, */
 		PCIE_ENGINE_DATA_INITIALIZER (PcieDdiEngine, 20, 23),
 		PCIE_DDI_DATA_INITIALIZER (ConnectorTypeDP, Aux2, Hdp2)
 	},
diff --git a/src/mainboard/amd/bettong/mptable.c b/src/mainboard/amd/bettong/mptable.c
index 744fd98..9e73e77 100644
--- a/src/mainboard/amd/bettong/mptable.c
+++ b/src/mainboard/amd/bettong/mptable.c
@@ -64,7 +64,6 @@ static void *smp_write_config_table(void *v)
 
 	smp_write_processors(mc);
 
-	//mptable_write_buses(mc, NULL, &bus_isa);
 	my_smp_write_bus(mc, 0, "PCI   ");
 	my_smp_write_bus(mc, 1, "PCI   ");
 	bus_isa = 0x02;



More information about the coreboot-gerrit mailing list