[coreboot-gerrit] New patch to review for coreboot: northbridge/via/vx800: Convert 'for (; ; )' to 'die'

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Tue Oct 11 19:10:50 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16989

-gerrit

commit 2fc5a5b3aed6e46bd34e29e2d4e598875756e54e
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Tue Oct 11 19:05:56 2016 +0200

    northbridge/via/vx800: Convert 'for (;;)' to 'die'
    
    Change-Id: I3f99190401d8df1415328da9c3b928194593901c
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/northbridge/via/vx800/freq_setting.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/via/vx800/freq_setting.c b/src/northbridge/via/vx800/freq_setting.c
index 6592efd..4eeba12 100644
--- a/src/northbridge/via/vx800/freq_setting.c
+++ b/src/northbridge/via/vx800/freq_setting.c
@@ -134,8 +134,8 @@ void CalcCLAndFreq(DRAM_SYS_ATTR * DramAttr)
 		}
 	}
 	if (!AllDimmSupportedCL) {	/*if equal 0, no supported CL */
-		PRINT_DEBUG_MEM("SPD Data Error, Can not get CL !!!! \r");
-		for (;;);
+		die("SPD Data Error, Can not get CL !!!! \r");
+
 	}
 
 	/*Get CL Value */
@@ -192,7 +192,7 @@ void CalcCLAndFreq(DRAM_SYS_ATTR * DramAttr)
 
 	if (CycTime <= 0) {
 		//error!
-		for (;;);
+		die("Error, cycle time <= 0\n");
 	}
 
 	/* cycle time value



More information about the coreboot-gerrit mailing list