[coreboot-gerrit] Patch set updated for coreboot: arch/riscv: Visually align trap frame information

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Wed Oct 12 11:33:59 CEST 2016


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16983

-gerrit

commit b3d4ecb4a01ae7fbba5b58bba8e93849f4298866
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Wed Oct 12 00:17:59 2016 +0200

    arch/riscv: Visually align trap frame information
    
    The pointers printed on unaligned memory accesses are now aligned to
    those printed at the end of print_trap_information.
    
    Change-Id: Ifec1cb639036ce61b81fe8d0a9b14c00d5b2781a
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/arch/riscv/trap_handler.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/arch/riscv/trap_handler.c b/src/arch/riscv/trap_handler.c
index 8120b66..3d3c7de 100644
--- a/src/arch/riscv/trap_handler.c
+++ b/src/arch/riscv/trap_handler.c
@@ -172,8 +172,8 @@ static uint32_t fetch_instruction(uintptr_t vaddr) {
 }
 
 void handle_misaligned_load(trapframe *tf) {
-	printk(BIOS_DEBUG, "Trapframe ptr: %p\n", tf);
-	printk(BIOS_DEBUG, "Stored sp: %p\n", (void*) tf->gpr[2]);
+	printk(BIOS_DEBUG, "Trapframe ptr:      %p\n", tf);
+	printk(BIOS_DEBUG, "Stored sp:          %p\n", (void*) tf->gpr[2]);
 	uintptr_t faultingInstructionAddr = tf->epc;
 	insn_t faultingInstruction = fetch_instruction(faultingInstructionAddr);
 	printk(BIOS_DEBUG, "Faulting instruction: 0x%x\n", faultingInstruction);
@@ -203,8 +203,8 @@ void handle_misaligned_load(trapframe *tf) {
 }
 
 void handle_misaligned_store(trapframe *tf) {
-	printk(BIOS_DEBUG, "Trapframe ptr: %p\n", tf);
-	printk(BIOS_DEBUG, "Stored sp: %p\n", (void*) tf->gpr[2]);
+	printk(BIOS_DEBUG, "Trapframe ptr:      %p\n", tf);
+	printk(BIOS_DEBUG, "Stored sp:          %p\n", (void*) tf->gpr[2]);
 	uintptr_t faultingInstructionAddr = tf->epc;
 	insn_t faultingInstruction = fetch_instruction(faultingInstructionAddr);
 	printk(BIOS_DEBUG, "Faulting instruction: 0x%x\n", faultingInstruction);



More information about the coreboot-gerrit mailing list