[coreboot-gerrit] Patch set updated for coreboot: nb/gm45, x4x/gma.c remove writes to nonexisting FDI registers

Arthur Heymans (arthur@aheymans.xyz) gerrit at coreboot.org
Wed Oct 12 14:44:10 CEST 2016


Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16993

-gerrit

commit 7270441044fd874ff25b701b824acb1d969176ec
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Wed Oct 12 01:49:16 2016 +0200

    nb/gm45,x4x/gma.c remove writes to nonexisting FDI registers
    
    This removes writes to FDI related registers since there is no FDI
    link on these targets. This is likely a remainder from copying code from
    later targets.
    
    TESTED on Thinkpad x200 (gm45)
    
    Change-Id: Id67fdc999185fa184a9ff0e5c3fc9bced04131ad
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/northbridge/intel/gm45/gma.c | 12 ------------
 src/northbridge/intel/x4x/gma.c  |  6 ------
 2 files changed, 18 deletions(-)

diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c
index 30c8d9a..8596193 100644
--- a/src/northbridge/intel/gm45/gma.c
+++ b/src/northbridge/intel/gm45/gma.c
@@ -305,14 +305,8 @@ static void gma_init_lvds(const struct northbridge_intel_gm45_config *info,
 	write32(mmio + PIPE_LINK_M1(0), link_m1);
 	write32(mmio + PIPE_LINK_N1(0), link_n1);
 
-	write32(mmio + 0x000f000c, 0x00002040);
-	mdelay(1);
-	write32(mmio + 0x000f000c, 0x00002050);
-	write32(mmio + 0x00060100, 0x00044000);
 	mdelay(1);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6);
-	write32(mmio + 0x000f0008, 0x00000040);
-	write32(mmio + 0x000f000c, 0x00022050);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
 	write32(mmio + PIPECONF(0), PIPECONF_ENABLE | PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
 
@@ -598,14 +592,8 @@ static void gma_init_vga(const struct northbridge_intel_gm45_config *info,
 	write32(mmio + PIPE_LINK_M1(0), link_m1);
 	write32(mmio + PIPE_LINK_N1(0), link_n1);
 
-	write32(mmio + 0x000f000c, 0x00002040);
-	mdelay(1);
-	write32(mmio + 0x000f000c, 0x00002050);
-	write32(mmio + 0x00060100, 0x00044000);
 	mdelay(1);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6);
-	write32(mmio + 0x000f0008, 0x00000040);
-	write32(mmio + 0x000f000c, 0x00022050);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
 	write32(mmio + PIPECONF(0), PIPECONF_ENABLE
 			| PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index 3f3ba2b..749a7c8 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -311,14 +311,8 @@ static void intel_gma_init(const struct northbridge_intel_x4x_config *info,
 	write32(mmio + PIPE_LINK_M1(0), link_m1);
 	write32(mmio + PIPE_LINK_N1(0), link_n1);
 
-	write32(mmio + 0x000f000c, 0x00002040);
-	mdelay(1);
-	write32(mmio + 0x000f000c, 0x00002050);
-	write32(mmio + 0x00060100, 0x00044000);
 	mdelay(1);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6);
-	write32(mmio + 0x000f0008, 0x00000040);
-	write32(mmio + 0x000f000c, 0x00022050);
 	write32(mmio + PIPECONF(0), PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
 	write32(mmio + PIPECONF(0), PIPECONF_ENABLE
 			| PIPECONF_BPP_6 | PIPECONF_DITHER_EN);



More information about the coreboot-gerrit mailing list