[coreboot-gerrit] New patch to review for coreboot: superiotool: Add undocumented registers of ITE IT8783E/F

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Wed Oct 12 17:09:02 CEST 2016


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17005

-gerrit

commit ad41463d9fdde3865f3b2594d2e06ae1b96c5343
Author: Nico Huber <nico.huber at secunet.com>
Date:   Thu Sep 29 12:22:30 2016 +0200

    superiotool: Add undocumented registers of ITE IT8783E/F
    
    Dumping and behavioral analysis have shown that there are more registers
    in the environment control of the IT8783E/F than documented in my data-
    sheet. This adds every register that wasn't 0x00/0xff by default. The
    default values are guesswork: those that looked like sensor readings
    became NANA, others are taken from dumps.
    
    Change-Id: I7e39700c9b98ed5be9f085bc8ffd848006310254
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 util/superiotool/ite.c | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c
index cc980af..43ccce1 100644
--- a/util/superiotool/ite.c
+++ b/util/superiotool/ite.c
@@ -934,24 +934,26 @@ static const struct superio_registers ec_table[] = {
 			 0x0a,0x0b,0x0c,0x0d,0x0e,0x0f,0x10,0x11,0x12,0x13,
 			 0x14,0x15,0x16,0x17,0x18,0x19,0x1a,0x1b,0x1c,0x1d,
 			 0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,
-			 0x2a,0x2b,0x30,0x31,0x32,0x33,0x34,0x35,0x36,0x37,
-			 0x38,0x39,0x3a,0x3b,0x3c,0x3d,0x3e,0x3f,0x40,0x41,
-			 0x42,0x43,0x44,0x45,0x50,0x51,0x52,0x53,0x54,0x55,
-			 0x56,0x57,0x58,0x59,0x5b,0x5c,0x5d,0x5e,0x5f,0x60,
-			 0x61,0x63,0x64,0x65,0x68,0x69,0x6b,0x6c,0x6d,0x70,
-			 0x71,0x73,0x74,0x75,0x88,0x89,0x8a,0x8b,0x8c,0x8d,
-			 0x8e,EOT},
+			 0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,0x30,0x31,0x32,0x33,
+			 0x34,0x35,0x36,0x37,0x38,0x39,0x3a,0x3b,0x3c,0x3d,
+			 0x3e,0x3f,0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,
+			 0x48,0x49,0x4a,0x4b,0x50,0x51,0x52,0x53,0x54,0x55,
+			 0x56,0x57,0x58,0x59,0x5a,0x5b,0x5c,0x5d,0x5e,0x5f,
+			 0x60,0x61,0x62,0x63,0x64,0x65,0x68,0x69,0x6a,0x6b,
+			 0x6c,0x6d,0x70,0x71,0x72,0x73,0x74,0x75,0x88,0x89,
+			 0x8a,0x8b,0x8c,0x8d,0x8e,EOT},
 			{0x18,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x80,
 			 0x54,0x09,0x00,NANA,NANA,NANA,MISC,MISC,MISC,0x07,
 			 0x50,MISC,MISC,MISC,NANA,NANA,NANA,MISC,MISC,MISC,
 			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
-			 NANA,NANA,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,
+			 NANA,NANA,NANA,NANA,NANA,NANA,MISC,MISC,MISC,MISC,
 			 MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,
-			 MISC,MISC,MISC,MISC,0x00,0x00,0x7f,0x7f,0x7f,0x50,
-			 0x00,0x00,0x90,0x00,0x12,0x60,0x00,0x00,0x00,0x7f,
-			 0x7f,0x00,0x00,0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x7f,
-			 0x7f,0x00,0x00,0x7f,MISC,0x00,0x00,0x00,0x00,MISC,
-			 0x02,EOT}},
+			 MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,0x5f,0x74,
+			 0x2d,0x40,0xab,0x22,0x00,0x00,0x7f,0x7f,0x7f,0x50,
+			 0x00,0x00,0x90,0x00,MISC,0x12,0x60,0x00,0x00,0x00,
+			 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x7f,0x7f,0x7f,0x00,
+			 0x00,0x7f,0x7f,0x7f,0x7f,0x00,0x00,0x7f,MISC,0x00,
+			 0x00,0x00,0x00,MISC,0x02,EOT}},
 		{EOT}}},
 	{EOT}
 };



More information about the coreboot-gerrit mailing list