[coreboot-gerrit] Patch set updated for coreboot: Fix Keyboard Interrupts and DSDT on Parrot (Acer C710)

Prabal Saha (coolstarorganization@gmail.com) gerrit at coreboot.org
Thu Oct 13 16:59:39 CEST 2016


Prabal Saha (coolstarorganization at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17017

-gerrit

commit bea1bda8c9518351d58e385934f273e77426428f
Author: Prabal Saha <coolstarorganization at gmail.com>
Date:   Thu Oct 13 07:52:23 2016 -0700

    Fix Keyboard Interrupts and DSDT on Parrot (Acer C710)
    
    Fix Interrupt issue in KConfig when not building with CONFIG_CHROMEOS.
    
    Windows doesn't like the SIO ACPI device because it is missing a
    	hardware id. No need to have keyboard under SIO as it's
            really an LPC device.
    
    Test: Build and boot on parrot-ivb. Observe working keyboard in
    	both Windows and Linux.
    
    Change-Id: Ia69e9b326001d2026b15b4ec03c94f7d03c8a700
    Signed-off-by: Prabal Saha <coolstarorganization at gmail.com>
---
 src/ec/compal/ene932/acpi/superio.asl | 5 -----
 src/mainboard/google/parrot/Kconfig   | 6 +++---
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/ec/compal/ene932/acpi/superio.asl b/src/ec/compal/ene932/acpi/superio.asl
index 8eba623..b373c90 100644
--- a/src/ec/compal/ene932/acpi/superio.asl
+++ b/src/ec/compal/ene932/acpi/superio.asl
@@ -15,12 +15,7 @@
 
 // Scope is \_SB.PCI0.LPCB
 
-Device (SIO) {
-	Name (_UID, 0)
-	Name (_ADR, 0)
-
 // Keyboard or AUX port (a.k.a Mouse)
 #ifdef SIO_EC_ENABLE_PS2K
 	#include <drivers/pc80/pc/ps2_controller.asl>
 #endif
-}
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index 974c58f..f2df885 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -15,12 +15,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select MAINBOARD_HAS_LPC_TPM
 	select INTEL_INT15
 
-config CHROMEOS
-	select VBOOT_VBNV_CMOS
-
 	# Workaround for EC/KBC IRQ1.
 	select SERIRQ_CONTINUOUS_MODE
 
+config CHROMEOS
+	select VBOOT_VBNV_CMOS
+
 config MAINBOARD_DIR
 	string
 	default google/parrot



More information about the coreboot-gerrit mailing list