[coreboot-gerrit] Patch set updated for coreboot: northbridge/amd/agesa: Remove commented code
HAOUAS Elyes (ehaouas@noos.fr)
gerrit at coreboot.org
Fri Oct 14 12:26:37 CEST 2016
HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16897
-gerrit
commit 1d78193d56d6c4624a0fe695da6ec3f4cbde710d
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date: Wed Oct 5 20:40:51 2016 +0200
northbridge/amd/agesa: Remove commented code
Change-Id: I08feb78763df15e6b9ccd2298a25ba2e6e3958f5
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
src/northbridge/amd/agesa/Kconfig | 4 ++++
src/northbridge/amd/agesa/agesawrapper.c | 5 -----
src/northbridge/amd/agesa/eventlog.c | 4 ++--
3 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/northbridge/amd/agesa/Kconfig b/src/northbridge/amd/agesa/Kconfig
index d5cff80..eb0de78 100644
--- a/src/northbridge/amd/agesa/Kconfig
+++ b/src/northbridge/amd/agesa/Kconfig
@@ -28,6 +28,10 @@ config S3_VGA_ROM_RUN
bool
default n
+config AGESA_EVENTLOG
+ bool
+ default n
+
source "src/northbridge/amd/agesa/*/Kconfig"
# TODO: Reservation for heap seems excessive
diff --git a/src/northbridge/amd/agesa/agesawrapper.c b/src/northbridge/amd/agesa/agesawrapper.c
index a72e239..e31eceb 100644
--- a/src/northbridge/amd/agesa/agesawrapper.c
+++ b/src/northbridge/amd/agesa/agesawrapper.c
@@ -188,11 +188,6 @@ AGESA_STATUS agesawrapper_amds3laterestore(void)
AmdInterfaceParams.NewStructSize = sizeof(AMD_S3LATE_PARAMS);
AmdCreateStruct(&AmdInterfaceParams);
-
-#if 0
- /* TODO: What to do with NvStorage here? */
- AmdS3LateParamsPtr->S3DataBlock.NvStorageSize = 0;
-#endif
AmdS3LateParamsPtr->S3DataBlock.VolatileStorageSize = 0;
OemS3LateRestore(AmdS3LateParamsPtr);
diff --git a/src/northbridge/amd/agesa/eventlog.c b/src/northbridge/amd/agesa/eventlog.c
index 0a40672..e704622 100644
--- a/src/northbridge/amd/agesa/eventlog.c
+++ b/src/northbridge/amd/agesa/eventlog.c
@@ -45,7 +45,7 @@ static const char * decodeAGESA_STATUS(AGESA_STATUS sret)
return statusStrings[sret];
}
-#if 0
+#if IS_ENABLED(CONFIG_AGESA_EVENTLOG)
/**
*
@@ -703,7 +703,7 @@ static void interpret_agesa_eventlog(EVENT_PARAMS *event)
break;
}
}
-#endif
+#endif /* IS_ENABLED(AGESA_EVENTLOG) */
static void amd_readeventlog(AMD_CONFIG_PARAMS *StdHeader)
{
More information about the coreboot-gerrit
mailing list