[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: clear PMC registers
Aaron Durbin (adurbin@chromium.org)
gerrit at coreboot.org
Fri Oct 14 17:47:13 CEST 2016
Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17027
-gerrit
commit d3f81592870bff0b39ce3de436927bee50ffc6e5
Author: Aaron Durbin <adurbin at chromium.org>
Date: Fri Oct 14 10:44:23 2016 -0500
soc/intel/apollolake: clear PMC registers
The clearing of the PMC registers was not being called resulting
in state persisting across reboots. This state is queried and
events are added to the eventlog like 'RTC reset' events. However,
the RTC reset event is a one time thing so it should only be logged
once. Without the clearing of the state the event was logged on
every boot.
BUG=chrome-os-partner:58496
Change-Id: I60aa7102977c2b1775ab8c54d1c147737d2af5e2
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/soc/intel/apollolake/pmc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c
index 4544e0d..ef39630 100644
--- a/src/soc/intel/apollolake/pmc.c
+++ b/src/soc/intel/apollolake/pmc.c
@@ -152,6 +152,9 @@ static void pmc_init(struct device *dev)
/* Log power state */
pch_log_state();
+
+ /* Now that things have been logged clear out the PMC state. */
+ clear_pmc_status();
}
static const struct device_operations device_ops = {
More information about the coreboot-gerrit
mailing list