[coreboot-gerrit] Patch set updated for coreboot: mainboard/emulation: Use C89 comments style & remove commented code

[HAOUAS Elyes (ehaouas@noos.fr)]

HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16916

-gerrit

commit 4ea946df276aa9f992882e338c106c25250d6e5a
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Fri Oct 7 13:02:31 2016 +0200

    mainboard/emulation: Use C89 comments style & remove commented code
    
    Change-Id: I627338505fe1273366bc8f6f528d829b3162b371
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/mainboard/emulation/qemu-i440fx/romstage.c   | 3 ---
 src/mainboard/emulation/qemu-power8/bootblock.c  | 5 +++--
 src/mainboard/emulation/qemu-power8/mainboard.c  | 2 +-
 src/mainboard/emulation/qemu-q35/acpi_tables.c   | 2 +-
 src/mainboard/emulation/qemu-q35/romstage.c      | 3 ---
 src/mainboard/emulation/spike-riscv/bootblock.c  | 5 +++--
 src/mainboard/emulation/spike-riscv/spike_util.c | 7 ++++---
 7 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/src/mainboard/emulation/qemu-i440fx/romstage.c b/src/mainboard/emulation/qemu-i440fx/romstage.c
index bc23929..1676fb0 100644
--- a/src/mainboard/emulation/qemu-i440fx/romstage.c
+++ b/src/mainboard/emulation/qemu-i440fx/romstage.c
@@ -40,9 +40,6 @@ void * asmlinkage romstage_main(unsigned long bist)
 	/* Halt if there was a built in self test failure */
 	report_bist_failure(bist);
 
-	//print_pci_devices();
-	//dump_pci_devices();
-
 	cbmem_was_initted = !cbmem_recovery(0);
 
 	timestamp_init(timestamp_get());
diff --git a/src/mainboard/emulation/qemu-power8/bootblock.c b/src/mainboard/emulation/qemu-power8/bootblock.c
index d92c169..5cfb7c1 100644
--- a/src/mainboard/emulation/qemu-power8/bootblock.c
+++ b/src/mainboard/emulation/qemu-power8/bootblock.c
@@ -17,8 +17,9 @@
 #include <console/console.h>
 #include <program_loading.h>
 
-// the qemu part of all this is very, very non-hardware like.
-// so it gets its own bootblock.
+/* The qemu part of all this is very, very non-hardware like.
+ * So it gets its own bootblock.
+ */
 void main(void)
 {
 	if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) {
diff --git a/src/mainboard/emulation/qemu-power8/mainboard.c b/src/mainboard/emulation/qemu-power8/mainboard.c
index 102f54c..41df2ca 100644
--- a/src/mainboard/emulation/qemu-power8/mainboard.c
+++ b/src/mainboard/emulation/qemu-power8/mainboard.c
@@ -26,7 +26,7 @@ static void mainboard_enable(device_t dev)
 			;
 	}
 
-	// Where does RAM live?
+	/* Where does RAM live? */
 	ram_resource(dev, 0, 2048, 32768);
 	cbmem_recovery(0);
 }
diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 07589e1..1b32c02 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -204,7 +204,7 @@ unsigned long acpi_fill_mcfg(unsigned long current)
 		return current;
 
 	reg = pci_read_config32(dev, 0x60);
-	if ((reg & 0x07) != 0x01)  // require enabled + 256MB size
+	if ((reg & 0x07) != 0x01)  /* require enabled + 256MB size */
 		return current;
 
 	current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *) current,
diff --git a/src/mainboard/emulation/qemu-q35/romstage.c b/src/mainboard/emulation/qemu-q35/romstage.c
index 1bb51da..870dd07 100644
--- a/src/mainboard/emulation/qemu-q35/romstage.c
+++ b/src/mainboard/emulation/qemu-q35/romstage.c
@@ -42,9 +42,6 @@ void * asmlinkage romstage_main(unsigned long bist)
 	/* Halt if there was a built in self test failure */
 	report_bist_failure(bist);
 
-	//print_pci_devices();
-	//dump_pci_devices();
-
 	cbmem_was_initted = !cbmem_recovery(0);
 
 	timestamp_init(timestamp_get());
diff --git a/src/mainboard/emulation/spike-riscv/bootblock.c b/src/mainboard/emulation/spike-riscv/bootblock.c
index 40a7de1..dc08c14 100644
--- a/src/mainboard/emulation/spike-riscv/bootblock.c
+++ b/src/mainboard/emulation/spike-riscv/bootblock.c
@@ -18,8 +18,9 @@
 #include <console/console.h>
 #include <program_loading.h>
 
-// the qemu part of all this is very, very non-hardware like.
-// so it gets its own bootblock.
+/* The qemu part of all this is very, very non-hardware like.
+ * So it gets its own bootblock.
+ */
 void main(void)
 {
 	if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) {
diff --git a/src/mainboard/emulation/spike-riscv/spike_util.c b/src/mainboard/emulation/spike-riscv/spike_util.c
index 7ddf16b..cbc9ad8 100644
--- a/src/mainboard/emulation/spike-riscv/spike_util.c
+++ b/src/mainboard/emulation/spike-riscv/spike_util.c
@@ -34,8 +34,9 @@
 #include <vm.h>
 
 uintptr_t translate_address(uintptr_t vAddr) {
-	// TODO: implement the page table translation algorithm
-	//uintptr_t pageTableRoot = read_csr(sptbr);
+	/* TODO: implement the page table translation algorithm
+	 * uintptr_t pageTableRoot = read_csr(sptbr);
+	 */
 	uintptr_t physAddrMask = 0xfffffff;
 	uintptr_t translationResult = vAddr & physAddrMask;
 	printk(BIOS_DEBUG, "Translated virtual address 0x%llx to physical address 0x%llx\n", vAddr, translationResult);
@@ -63,7 +64,7 @@ uintptr_t mcall_send_ipi(uintptr_t recipient)
 
 uintptr_t mcall_clear_ipi(void)
 {
-	// only clear SSIP if no other events are pending
+	/* only clear SSIP if no other events are pending */
 	if (HLS()->device_response_queue_head == NULL) {
 		clear_csr(mip, MIP_SSIP);
 		mb();