[coreboot-gerrit] Patch merged into coreboot/master: libpayload: Replace majority of timer drivers with a generic one

gerrit at coreboot.org gerrit at coreboot.org
Mon Oct 17 22:43:41 CEST 2016


the following patch was just integrated into master:
commit 4fda9bd0ec15d5d2cbc647811b46c0a23fdb865e
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon May 16 15:39:12 2016 -0700

    libpayload: Replace majority of timer drivers with a generic one
    
    Currently every non-x86 platform supported by libpayload needs to
    provide its own timer driver. Most of the ones we have accumulated there
    look almost identical: For the frequency, return a preset constant. For
    the value, read a 32-bit register, possibly read another 32-bit register
    and shift+OR it with the previous one, then return that.
    
    Let's replace this with a single .c file that can easily handle all of
    those cases. Menuconfig convenience can still be maintained by providing
    several presets that select different defaults for the driver's
    configuration options (register address(es) and frequency).
    
    Removes an "enabled" check from Samsung MCT driver since coreboot always
    unconditionally enables that timer anyway.
    
    CQ-DEPEND=CL:344809
    BRANCH=None
    BUG=None
    TEST=Booted Oak and Veyron, observed how dev-mode delay was still ~30s
    
    Change-Id: I61cb7d2ffd4902aa841c57f9afa9cd991f770acd
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Commit-Id: a036af6
    Original-Change-Id: I9784e7c6aa5abd6d92478ea7ec1cf42c9a437546
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/347749
    Reviewed-on: https://review.coreboot.org/17023
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.h at gmx.de>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/17023 for details.

-gerrit



More information about the coreboot-gerrit mailing list