[coreboot-gerrit] Patch set updated for coreboot: northbridge/intel/i5000: Convert 'for(; ; )' to 'die'

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Wed Oct 19 12:34:20 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17006

-gerrit

commit 590533a59b450a319e5b7b3fc36af9d3e97044ea
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Wed Oct 12 19:57:38 2016 +0200

    northbridge/intel/i5000: Convert 'for(;;)' to 'die'
    
    Change-Id: I1ceea759a40d740503bde725ad6d72fab4aa7971
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/northbridge/intel/i5000/raminit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/northbridge/intel/i5000/raminit.c b/src/northbridge/intel/i5000/raminit.c
index 1a802b0..de05cc2 100644
--- a/src/northbridge/intel/i5000/raminit.c
+++ b/src/northbridge/intel/i5000/raminit.c
@@ -353,8 +353,7 @@ static int i5000_amb_smbus_write(struct i5000_fbdimm *d,  int byte1, int byte2)
 
 	printk(BIOS_ERR, "SMBus write failed: %d/%d/%d, byte1 %02x, byte2 %02x status %04x\n",
 	       d->branch->num, d->channel->num, d->num, byte1, byte2, status);
-	for (;;);
-	return -1;
+	die("Error: SMBus write failed");
 }
 
 static int i5000_amb_smbus_read(struct i5000_fbdimm *d, int byte1, u8 *out)



More information about the coreboot-gerrit mailing list