[coreboot-gerrit] New patch to review for coreboot: nb/intel/i945: Add PCI id for I945GC

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Sat Oct 22 20:08:35 CEST 2016


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17095

-gerrit

commit ec688c139eb7cc6ca7c967903976f71a6d43e26c
Author: Nico Huber <nico.h at gmx.de>
Date:   Sat Oct 22 20:01:34 2016 +0200

    nb/intel/i945: Add PCI id for I945GC
    
    Also drop an odd comment about the resource allocator which seems to
    work fine, with the right id.
    
    Change-Id: I9099211fe946c28f90dd7730345b81a3f7f6f545
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 src/northbridge/intel/i945/northbridge.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c
index ba8b251..5d18591 100644
--- a/src/northbridge/intel/i945/northbridge.c
+++ b/src/northbridge/intel/i945/northbridge.c
@@ -177,11 +177,6 @@ static void mc_read_resources(device_t dev)
 
 	pci_dev_read_resources(dev);
 
-	/* So, this is one of the big mysteries in the coreboot resource
-	 * allocator. This resource should make sure that the address space
-	 * of the PCIe memory mapped config space bar. But it does not.
-	 */
-
 	/* We use 0xcf as an unused index for our PCIe bar so that we find it again */
 	resource = new_resource(dev, 0xcf);
 	resource->base = DEFAULT_PCIEXBAR;
@@ -254,8 +249,10 @@ static struct device_operations mc_ops = {
 	.ops_pci          = &intel_pci_ops,
 };
 
-static const unsigned short pci_device_ids[] = { 0x27a0, 0x27ac,
-						 0 };
+static const unsigned short pci_device_ids[] = {
+	0x2770, /* desktop */
+	0x27a0, 0x27ac, /* mobile */
+	0 };
 
 static const struct pci_driver mc_driver __pci_driver = {
 	.ops    = &mc_ops,



More information about the coreboot-gerrit mailing list